Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix yum proxy username/password handling #47435

Merged
merged 3 commits into from
Oct 23, 2018
Merged

fix yum proxy username/password handling #47435

merged 3 commits into from
Oct 23, 2018

Conversation

maxamillion
Copy link
Contributor

SUMMARY

backport(cherry-pick) of 46291 (cherry picked from commit e4a4357)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yum

@maxamillion
fix yum proxy username/password handling
77b921d 
Fixes ansible#46249

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit e4a4357)
@maxamillion
add backport changelog
5150cc7 
Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Oct 23, 2018

Hi @maxamillion, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 23, 2018

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

changelogs/fragments/yum-proxy-userpass.yaml:4:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 23, 2018

cc @Akasurde @berenddeschouwer @kustodian @verm666
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 23, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 23, 2018
@abadger abadger merged commit 2d39ad0 into ansible:stable-2.7 Oct 23, 2018
@abadger
Copy link
Contributor

abadger commented Oct 23, 2018

Merged for the 2.7.1 release

@webknjaz webknjaz removed needs_triage Needs a first human triage before being processed. labels Oct 23, 2018
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@maxamillion @ansibot @abadger @dagwieers @webknjaz