2.7: user: do not pass ssh_key_passphrase on cmdline

[mkrizek]

SUMMARY

CVE-2018-16837

Co-authored-by: Toshio Kuratomi a.badger@gmail.com
(cherry picked from commit a0aa53d)

Backport of #47436

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

user

ANSIBLE VERSION

2.7

ADDITIONAL INFORMATION

[ansibot]

Hi @mkrizek, thank you for submitting this pull-request!

click here for bot help

[ansibot]

The test ansible-test sanity --test changelog [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/changelog.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "packaging/release/changelogs/changelog.py", line 814, in <module>
    main()
  File "packaging/release/changelogs/changelog.py", line 98, in main
    args.func(args)
  File "packaging/release/changelogs/changelog.py", line 109, in command_lint
    lint_fragments(fragments, exceptions)
  File "packaging/release/changelogs/changelog.py", line 227, in lint_fragments
    errors += linter.lint(fragment)
  File "packaging/release/changelogs/changelog.py", line 307, in lint
    errors += [(fragment.path, 0, 0, result[1]) for result in results]
  File "packaging/release/changelogs/changelog.py", line 307, in <listcomp>
    errors += [(fragment.path, 0, 0, result[1]) for result in results]
  File "/usr/local/lib/python3.6/dist-packages/rstcheck.py", line 169, in check
    find_ignored_languages(source)
  File "/usr/local/lib/python3.6/dist-packages/rstcheck.py", line 235, in find_ignored_languages
    for (index, line) in enumerate(source.splitlines()):
AttributeError: 'dict' object has no attribute 'splitlines'
Traceback (most recent call last):
  File "test/sanity/code-smell/changelog.py", line 14, in <module>
    main()
  File "test/sanity/code-smell/changelog.py", line 10, in main
    subprocess.check_call(cmd)
  File "/usr/lib/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['packaging/release/changelogs/changelog.py', 'lint', 'changelogs/fragments/user-do-not-pass-ssh_key_passphrase-on-cmdline.yaml']' returned non-zero exit status 1.

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/system/user.py:876:21: E210 subprocess.Popen call found. Should be module.run_command

click here for bot help

[ansibot]

cc @samdoran @sfromm
click here for bot help

[ansibot]

cc @mattclay
click here for bot help

[abadger]

Merged for the 2.7.1 release.

@mattclay @nitzmahone, you'll probably want to cherry-pick from this PR for the stable-2.6 and stable-2.5 branches as it consolidates the fix and all of the follow on commits.