Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't restrict disable_excludes choices incorrectly #47453

Merged
merged 2 commits into from
Oct 23, 2018
Merged

don't restrict disable_excludes choices incorrectly #47453

merged 2 commits into from
Oct 23, 2018

Conversation

maxamillion
Copy link
Contributor

Signed-off-by: Adam Miller admiller@redhat.com

SUMMARY

Fixes #47085

The choices option should not have been set for the disable_excludes parameter in the yum and dnf argument spec because it incorrectly restricts the input possibilities.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yum
dnf

ANSIBLE VERSION
ansible 2.8.0.dev0 (bugfix/47085-yumdnf-disable-excludes 31c1e2adf8) last updated 2018/10/22 16:27:17 (GMT -500)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/admiller/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/admiller/src/dev/ansible/lib/ansible
  executable location = /home/admiller/src/dev/ansible/bin/ansible
  python version = 2.7.15 (default, Sep 21 2018, 23:26:48) [GCC 8.1.1 20180712 (Red Hat 8.1.1-5)]

@maxamillion
don't restrict disable_excludes choices incorrectly
31c1e2a 
Fixes ansible#47085

Signed-off-by: Adam Miller <admiller@redhat.com>
@abadger
Copy link
Contributor

abadger commented Oct 22, 2018

+1 to merge. We'll want a changelog entry in order to backport this

@abadger
Copy link
Contributor

abadger commented Oct 22, 2018

shippable is waiting on azure but has already failed. Docuemntation needs to be updated to match the argument spec change

@ansibot
Copy link
Contributor

ansibot commented Oct 23, 2018

Hi @maxamillion, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 23, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/packaging/os/dnf.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "disable_excludes" does not match the documentation (['all', 'main', 'repoid'])
lib/ansible/modules/packaging/os/yum.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "disable_excludes" does not match the documentation (['all', 'main', 'repoid'])

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 23, 2018
@maxamillion
fix docs and add changelog
d42446b 
Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Oct 23, 2018

cc @Akasurde @berenddeschouwer @kustodian @verm666
click here for bot help

@ansibot ansibot added module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. core_review In order to be merged, this PR must follow the core review workflow. and removed needs_triage Needs a first human triage before being processed. small_patch needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 23, 2018
@maxamillion maxamillion merged commit 0e3e646 into ansible:devel Oct 23, 2018
maxamillion added a commit to maxamillion/ansible that referenced this pull request Oct 23, 2018
@maxamillion
don't restrict disable_excludes choices incorrectly (ansible#47453)
e0a0bbd 
* don't restrict disable_excludes choices incorrectly

Fixes ansible#47085

(cherry picked from commit 0e3e646)
Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion maxamillion mentioned this pull request Oct 23, 2018
Merged
abadger pushed a commit that referenced this pull request Oct 23, 2018
@maxamillion @abadger
don't restrict disable_excludes choices incorrectly (#47453)
916b1e3 
* don't restrict disable_excludes choices incorrectly

Fixes #47085

(cherry picked from commit 0e3e646)
Signed-off-by: Adam Miller <admiller@redhat.com>
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@maxamillion @Tomorrow9
don't restrict disable_excludes choices incorrectly (ansible#47453)
d3e995a 
* don't restrict disable_excludes choices incorrectly

Fixes ansible#47085

Signed-off-by: Adam Miller <admiller@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disable_excludes option for yum module doesn't accept Yum repository ids
3 participants
@maxamillion @abadger @ansibot