Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnf properly gpg check local packages based on param #47455

Merged
merged 2 commits into from
Oct 23, 2018
Merged

dnf properly gpg check local packages based on param #47455

merged 2 commits into from
Oct 23, 2018

Conversation

maxamillion
Copy link
Contributor

Fixes #43624

Signed-off-by: Adam Miller admiller@redhat.com

SUMMARY

properly gpg check local packages (on the local disk of the remote node) based on param provided by the user

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

dnf

ANSIBLE VERSION
ansible 2.8.0.dev0 (bugfix/43624-dnf-localgpgcheck 807684ff8b) last updated 2018/10/22 17:22:32 (GMT -500)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/admiller/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/admiller/src/dev/ansible/lib/ansible
  executable location = /home/admiller/src/dev/ansible/bin/ansible
  python version = 2.7.15 (default, Sep 21 2018, 23:26:48) [GCC 8.1.1 20180712 (Red Hat 8.1.1-5)]

@maxamillion
dnf properly gpg check local packages based on param
807684f 
Fixes ansible#43624

Signed-off-by: Adam Miller <admiller@redhat.com>
@abadger
Copy link
Contributor

abadger commented Oct 22, 2018

+1 to merge and backport. Please add a changelog entry for it.

@ansibot
Copy link
Contributor

ansibot commented Oct 22, 2018

Hi @maxamillion, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. shipit This PR is ready to be merged by Core small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 22, 2018
@maxamillion
add changelog
1d32bbd 
Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. and removed shipit This PR is ready to be merged by Core small_patch labels Oct 23, 2018
@maxamillion maxamillion merged commit 079705f into ansible:devel Oct 23, 2018
maxamillion added a commit to maxamillion/ansible that referenced this pull request Oct 23, 2018
@maxamillion
dnf properly gpg check local packages based on param (ansible#47455)
cacce8b 
* dnf properly gpg check local packages based on param

Fixes ansible#43624

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 079705f)
@maxamillion maxamillion mentioned this pull request Oct 23, 2018
Merged
abadger pushed a commit that referenced this pull request Oct 23, 2018
@maxamillion @abadger
dnf properly gpg check local packages based on param (#47455)
96b57a5 
* dnf properly gpg check local packages based on param

Fixes #43624

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 079705f)
@mkrizek mkrizek removed needs_triage Needs a first human triage before being processed. labels Oct 25, 2018
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@maxamillion @Tomorrow9
dnf properly gpg check local packages based on param (ansible#47455)
53a38a2 
* dnf properly gpg check local packages based on param

Fixes ansible#43624

Signed-off-by: Adam Miller <admiller@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible DNF module fails to do GPG checking when installing RPMs from filesystem
4 participants
@maxamillion @abadger @ansibot @mkrizek