VMware: correct logic to pass ESXi SSL thumbprint #47600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pdellaert @dericcrago @Im0 @tchernomax Could you please review this ? |
|
Hi @Akasurde, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
ansibot
added
shipit
Akasurde
removed
the
needs_triage
Due to refactoring of task_error and wait_for_task method, SSL thumbprint was lost in error message. This fixes the retry mechanism of AddHost task. Fixes: ansible#47563 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot
added
core_review
Akasurde
added a commit
to Akasurde/ansible
that referenced
this pull request
Oct 29, 2018
Due to refactoring of task_error and wait_for_task method, SSL thumbprint was lost in error message. This fixes the retry mechanism of AddHost task. Fixes: ansible#47563 (cherry picked from commit e7c83d6) Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
Due to refactoring of task_error and wait_for_task method, SSL thumbprint was lost in error message. This fixes the retry mechanism of AddHost task. Fixes: ansible#47563 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Due to refactoring of task_error and wait_for_task method,
SSL thumbprint was lost in error message. This fixes the
retry mechanism of AddHost task.
Fixes: #47563
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/module_utils/vmware.py
lib/ansible/modules/cloud/vmware/vmware_host.py
ANSIBLE VERSION