Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_host_network: Fix type conversion #47617

Merged
merged 1 commit into from
Oct 29, 2018
Merged

ovirt_host_network: Fix type conversion #47617

merged 1 commit into from
Oct 29, 2018

Conversation

machacekondra
Copy link
Contributor

SUMMARY

When user specify bond mode option as integer, module always report state as CHANGED.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_host_network

ANSIBLE VERSION
2.7.1
ADDITIONAL INFORMATION

When you run multiple times:

- name: Create bond
    ovirt_host_network:
      auth: "{{ ovirt_auth }}"
      name: myhost
      bond:
        name: bond0
        mode: 1
        options:
          miimon: '200'
        interfaces:
          - eth0
          - eth1
      networks:
       - name: ovirtmgmt
         boot_protocol: dhcp
      save: true
      check: true

You always get CHANGED. Report OK, as there are no changes.

@machacekondra
ovirt_host_network: Fix type conversion
0872dd1 
Signed-off-by: Ondra Machacek <omachace@redhat.com>
@machacekondra machacekondra force-pushed the ovirt_host_network_type_conversion branch from 54f7c7d to 0872dd1 Compare October 25, 2018 12:25
mwperina
mwperina approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot
Copy link
Contributor

ansibot commented Oct 25, 2018

Hi @machacekondra, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 25, 2018

cc @mwperina
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. labels Oct 25, 2018
@mwperina
Copy link
Contributor

shipit

mwperina
mwperina approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@machacekondra
Copy link
Contributor Author

shipit

@mwperina
Copy link
Contributor

Toshio, could you please merge, so we can backport? It seems that if we add a changelog for patch, then our automerge for ovirt modules doesn't work ...

@abadger

@gundalow gundalow merged commit 36b0aed into ansible:devel Oct 29, 2018
@gundalow
Copy link
Contributor

@machacekondra Thank you for the PR
@mwperina Thank you for the review.

Merged into devel for release in Ansible 2.8.

Pilou is working on a fix so Ansibullbot will merge changelog/fragments

@machacekondra machacekondra mentioned this pull request Oct 30, 2018
Merged
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@machacekondra @Tomorrow9
ovirt_host_network: Fix type conversion (ansible#47617)
7f3c023 
Signed-off-by: Ondra Machacek <omachace@redhat.com>
@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@machacekondra @ansibot @mwperina @gundalow @dagwieers