Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing self._supports_async to uri action plugin #47677

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Add missing self._supports_async to uri action plugin #47677

merged 3 commits into from
Oct 26, 2018

Conversation

sivel
Copy link
Member

@sivel sivel commented Oct 26, 2018

SUMMARY

Add missing self._supports_async to uri action plugin. Fixes #47660

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/action/uri.py

ANSIBLE VERSION
2.7
2.8
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 26, 2018

Hi @sivel, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 26, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Oct 26, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 26, 2018
@sivel sivel merged commit 3633e21 into ansible:devel Oct 26, 2018
sivel added a commit to sivel/ansible that referenced this pull request Oct 26, 2018
@sivel
[stable-2.7] Add missing self._supports_async to uri action plugin (a…
03601c6 
…nsible#47677)

* Add missing self._supports_async to uri action plugin. Fixes ansible#47660

* Additional changes needed to support async

* Missed a call to execute_module
(cherry picked from commit 3633e21)

Co-authored-by: Matt Martz <matt@sivel.net>
abadger pushed a commit that referenced this pull request Oct 31, 2018
@sivel @abadger
[stable-2.7] Add missing self._supports_async to uri action plugin (#…
414ee47 
…47677)

* Add missing self._supports_async to uri action plugin. Fixes #47660

* Additional changes needed to support async

* Missed a call to execute_module
(cherry picked from commit 3633e21)

Co-authored-by: Matt Martz <matt@sivel.net>
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@sivel @Tomorrow9
Add missing self._supports_async to uri action plugin (ansible#47677)
9a539fb 
* Add missing self._supports_async to uri action plugin. Fixes ansible#47660

* Additional changes needed to support async

* Missed a call to execute_module
@dagwieers dagwieers added the net_tools Net-tools category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URI module does not support async mode
5 participants
@sivel @ansibot @bcoca @dagwieers @mkrizek