Make wait_for return matched groups defined in search_regex. Closes #… #47690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bjorm, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
This comment has been minimized.
This comment has been minimized.
ansibot
added
ci_verified
jborean93
removed
the
needs_triage
ansibot
added
the
stale_ci
ansibot
removed
the
stale_ci
mattclay
requested changes
Nov 17, 2018
ansibot
added
needs_revision
added 3 commits
November 17, 2018 12:45
- Use output_dir instead of hardcoded /tmp for temp files - Sleep for only 3s instead of 10s - Revert indent change
|
|
dagwieers
approved these changes
Nov 19, 2018
abadger
reviewed
Nov 20, 2018
| @@ -98,7 +121,7 @@ | |||
| - "waitfor.msg == 'fail with custom message'" | |||
|
|
|||
| - name: setup start SimpleHTTPServer | |||
| shell: sleep 10 && cd {{ files_dir }} && {{ ansible_python.executable }} {{ output_dir}}/testserver.py {{ http_port }} | |||
| shell: sleep 3 && cd {{ files_dir }} && {{ ansible_python.executable }} {{ output_dir}}/testserver.py {{ http_port }} | |||
There was a problem hiding this comment.
Why change sleep here? It seems like that might have been tuned for timing in CI or similar. If it's just to take less time maybe we should change it in a separate PR.
There was a problem hiding this comment.
And the same comment for all the other timing changes.
|
A change like this should get a changelog fragment. You can look at files in https://github.com/ansible/ansible/tree/devel/changelogs/fragments for what it should look like. This should be listed as a minor_changes as it adds a minor feature to a module. |
mjmayer
pushed a commit
to mjmayer/ansible
that referenced
this pull request
Nov 30, 2018
ansible#47690) * Make wait_for return matched groups defined in search_regex. Closes ansible#25020. * Fix formatting issues. * Fix issues raised in review. - Use output_dir instead of hardcoded /tmp for temp files - Sleep for only 3s instead of 10s - Revert indent change
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
ansible#47690) * Make wait_for return matched groups defined in search_regex. Closes ansible#25020. * Fix formatting issues. * Fix issues raised in review. - Use output_dir instead of hardcoded /tmp for temp files - Sleep for only 3s instead of 10s - Revert indent change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…25020.
SUMMARY
Fixes #25020
Add module return values
match_groupsandmatch_groupdictthat contain any matched groups defined insearch_regex.ISSUE TYPE
COMPONENT NAME
wait_for
ANSIBLE VERSION
ADDITIONAL INFORMATION