Add support for Windows hosts in the SSH connection plugin

[jborean93]

SUMMARY

2nd attempt at implementing Windows support with the SSH connection plugin. Basic tests indicate exec, fetch, and copy all work fine over SSH.

Known issues:

• The piped transfer method does not work, it uses the dd command which Windows does not support
• Fetch does not work with network files, this seems to be a bug with powershell.py shell plugin that strips out the leading \\ chars in the network path
• Probably a lot of other things

Very basic timing checks, ssh is still roughly .2 seconds slower than the winrm plugin on a win_ping adhoc command but exponentially faster with file copy operations as expected.

Fixes #25344

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

ssh

ANSIBLE VERSION

devel

[ansibot]

Hi @jborean93, thank you for submitting this pull-request!

click here for bot help

[ansibot]

cc @nitzmahone
click here for bot help

[ansibot]

cc @mattclay
click here for bot help

[mattclay]

@jborean93 We'll want additional logic in the ansible-test change classification code to handle this.

We already have this logic:

ansible/test/runner/lib/classification.py

Lines 419 to 422 in 4ec2423

	integration_name = 'connection_%s' % name
	if integration_name not in self.integration_targets_by_name:
	integration_name = None

We probably need to add something like this:

            windows_integration_name = 'connection_windows_%s' % name

            if windows_integration_name not in self.integration_targets_by_name:
                windows_integration_name = None

Then add it to the return values here:

ansible/test/runner/lib/classification.py

Lines 447 to 450 in 4ec2423

	return {
	'integration': integration_name,
	'units': units_path,
	}

[ansibot]

cc @acozine
click here for bot help

[matsmcp]

I new to Ansible but not to Windows or scripting.
Requiring Powershell as defaultshell has a good chance to break existing scripts that uses built in commands from CMD.exe.

It shoudn't be that much job to rewrite thoose scripts though and as I understand it WINRM could still be used if a rewrite isn't doable.

For me the main benefit with SSH transport is the possibility to use jump/bastion-hosts to reach the systems I want to manage. Can I live with having powershell as defaultshell to get that capability - H-ll Yes !
Therefore I would like to wote for shipping with the documented limitation that the module currently requires Powershell as shell

[jborean93]

@matsmcp the latest commit adds support for the default shell choice of cmd. So this can now work with both cmd and PowerShell as the DefaultShell. You just need to set ansible_shell_type: cmd or ansible_shell_type: powershell based ok what the Windows host is currently configured with. This should be reflected in the docs that have been added.

[nitzmahone]

Just the one suggestion about setting the shell type in inventory, otherwise looking good. Code itself is ready to merge IMO.

Some wordsmithing and spelling/grammar tweaks needed needed in the docs, but I'll let @acozine do her thing with that, as she may want reorg or changes anyway.

[matsmcp]

@jborean93

That sounds great.

[acozine]

I added a couple of commits with most of my docs change ideas. I forgot the changelog fragment, though, so adding that here.

[nitzmahone]

unrelated SSL failure on Ubuntu