Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates variables docs: facts examples, headers, links, etc. #47767

Merged
merged 14 commits into from
Oct 30, 2018

Conversation

acozine
Copy link
Contributor

@acozine acozine commented Oct 29, 2018

SUMMARY

The example output on https://docs.ansible.com/ansible/devel/user_guide/playbooks_variables.html#information-discovered-from-systems-facts for Ansible facts was taken from Ansible 1.4.

This PR updates the example output to 2.7. It also updates the headers and links and makes some minor edits.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs.ansible.com

ANSIBLE VERSION

2.7

@ansibot
Copy link
Contributor

ansibot commented Oct 29, 2018

Hi @acozine, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 29, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Oct 29, 2018
"network": "REDACTED",
"type": "ether"
},
"ansible_default_ipv6": {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly a nit-pick, but it could help to have the default ipv6 fields shown here as well, for completeness' sake.

Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can always add IPv6 details in follow up PR

@samccann samccann merged commit 7db6385 into ansible:devel Oct 30, 2018
@samccann samccann added this to To do in OLD Ansible Documentation via automation Oct 30, 2018
samccann pushed a commit to samccann/ansible that referenced this pull request Nov 5, 2018
…#47767)

* refreshes ansible facts output and updates some references/headers

(cherry picked from commit 7db6385)
abadger pushed a commit that referenced this pull request Nov 5, 2018
* refreshes ansible facts output and updates some references/headers

(cherry picked from commit 7db6385)
@acozine acozine moved this from To do to Backport to 2.7 in OLD Ansible Documentation Nov 7, 2018
@acozine acozine deleted the update_facts branch November 29, 2018 20:40
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
…#47767)

* refreshes ansible facts output and updates some references/headers
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants