k8s_facts: fix handling of unknown resource types #47857

mmazur · 2018-10-31T12:48:58Z

SUMMARY

k8s_facts can be asked about resource kind/apiver combinations that it knows nothing about. This patch makes the code handle such a case gracefully.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

modules/clustering/k8s/k8s_facts

ANSIBLE VERSION

  config file = None
  configured module search path = [u'/home/mmazur/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/mmazur/.local/lib/python2.7/site-packages/ansible
  executable location = /home/mmazur/.local/bin/ansible
  python version = 2.7.15 (default, Sep 21 2018, 23:28:06) [GCC 8.2.1 20180801 (Red Hat 8.2.1-2)]

ADDITIONAL INFORMATION

A full trace of what happens when running k8s_facts with a non–existant kind/apiver combo, in which case K8sAnsibleMixin.find_resource returns None while called from kubernetes_facts() function:

Traceback (most recent call last):
  File "/home/mmazur/.ansible/tmp/ansible-tmp-1540988557.34-258232659169781/AnsiballZ_k8s_facts.py", line 113, in <module>
    _ansiballz_main()
  File "/home/mmazur/.ansible/tmp/ansible-tmp-1540988557.34-258232659169781/AnsiballZ_k8s_facts.py", line 105, in _ansiballz_main
    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
  File "/home/mmazur/.ansible/tmp/ansible-tmp-1540988557.34-258232659169781/AnsiballZ_k8s_facts.py", line 48, in invoke_module
    imp.load_module('__main__', mod, module, MOD_DESC)
  File "/tmp/ansible_k8s_facts_payload_JmbBNj/__main__.py", line 176, in <module>
  File "/tmp/ansible_k8s_facts_payload_JmbBNj/__main__.py", line 172, in main
  File "/tmp/ansible_k8s_facts_payload_JmbBNj/__main__.py", line 153, in execute_module
  File "/tmp/ansible_k8s_facts_payload_JmbBNj/ansible_k8s_facts_payload.zip/ansible/module_utils/k8s/common.py", line 202, in kubernetes_facts
AttributeError: 'NoneType' object has no attribute 'get'

fatal: [localhost]: FAILED! => {
    "changed": false, 
    "module_stderr": "Traceback (most recent call last):\n  File \"/home/mmazur/.ansible/tmp/ansible-tmp-1540988557.34-258232659169781/AnsiballZ_k8s_facts.py\", line 113, in <module>\n    _ansiballz_main()\n  File \"/home/mmazur/.ansible/tmp/ansible-tmp-1540988557.34-258232659169781/AnsiballZ_k8s_facts.py\", line 105, in _ansiballz_main\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n  File \"/home/mmazur/.ansible/tmp/ansible-tmp-1540988557.34-258232659169781/AnsiballZ_k8s_facts.py\", line 48, in invoke_module\n    imp.load_module('__main__', mod, module, MOD_DESC)\n  File \"/tmp/ansible_k8s_facts_payload_JmbBNj/__main__.py\", line 176, in <module>\n  File \"/tmp/ansible_k8s_facts_payload_JmbBNj/__main__.py\", line 172, in main\n  File \"/tmp/ansible_k8s_facts_payload_JmbBNj/__main__.py\", line 153, in execute_module\n  File \"/tmp/ansible_k8s_facts_payload_JmbBNj/ansible_k8s_facts_payload.zip/ansible/module_utils/k8s/common.py\", line 202, in kubernetes_facts\nAttributeError: 'NoneType' object has no attribute 'get'\n", 
    "module_stdout": "", 
    "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", 
    "rc": 1
}
        to retry, use: --limit @/home/mmazur/dev/ansible-kubevirt-modules/tests/playbooks/kubevirt_facts_vmipreset.retry

ansibot · 2018-10-31T12:57:34Z

Hi @mmazur, thank you for submitting this pull-request!

click here for bot help

ansibot · 2018-10-31T12:57:35Z

cc @chouseknecht @fabianvf @flaper87 @maxamillion @willthames
click here for bot help

willthames · 2018-10-31T13:03:37Z

This is great, thanks @mmazur!

willthames · 2018-10-31T13:04:16Z

candidate for 2.7 backport

willthames · 2018-10-31T13:05:41Z

Because this is a candidate for a 2.7 backport, and all backports need a changelog fragment, could you add one please (or just update the existing https://github.com/ansible/ansible/blob/devel/changelogs/fragments/k8s_facts_fix.yaml)

mmazur · 2018-10-31T14:10:50Z

@willthames you mean I should update this PR with a change to changelogs/fragments/k8s_facts_fix.yaml adding a oneliner for my change, right?

Akasurde · 2018-10-31T15:19:25Z

@mmazur Yes, update PR by adding one line stating -

- fix handling of unknown resource types.

here

mmazur · 2018-10-31T15:29:29Z

Done.

Akasurde

LGTM

changelogs/fragments/k8s_facts_fix.yaml

ansibot · 2018-11-01T23:43:08Z

The test ansible-test sanity --test changelog [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/changelog.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "packaging/release/changelogs/changelog.py", line 814, in <module>
    main()
  File "packaging/release/changelogs/changelog.py", line 98, in main
    args.func(args)
  File "packaging/release/changelogs/changelog.py", line 109, in command_lint
    lint_fragments(fragments, exceptions)
  File "packaging/release/changelogs/changelog.py", line 227, in lint_fragments
    errors += linter.lint(fragment)
  File "packaging/release/changelogs/changelog.py", line 307, in lint
    errors += [(fragment.path, 0, 0, result[1]) for result in results]
  File "packaging/release/changelogs/changelog.py", line 307, in <listcomp>
    errors += [(fragment.path, 0, 0, result[1]) for result in results]
  File "/usr/local/lib/python3.6/dist-packages/rstcheck.py", line 169, in check
    find_ignored_languages(source)
  File "/usr/local/lib/python3.6/dist-packages/rstcheck.py", line 235, in find_ignored_languages
    for (index, line) in enumerate(source.splitlines()):
AttributeError: 'dict' object has no attribute 'splitlines'
Traceback (most recent call last):
  File "test/sanity/code-smell/changelog.py", line 14, in <module>
    main()
  File "test/sanity/code-smell/changelog.py", line 10, in main
    subprocess.check_call(cmd)
  File "/usr/lib/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['packaging/release/changelogs/changelog.py', 'lint', 'changelogs/fragments/2.8-core-deprecations.yaml', 'changelogs/fragments/2.8-removed-modules.yaml', 'changelogs/fragments/33754-docker_image_fix_changed_in_force_mode.yaml', 'changelogs/fragments/35370-add_support_for_docker_network_internal_flag.yaml', 'changelogs/fragments/42866-galaxy-search-unicode.yaml', 'changelogs/fragments/43123-add_support_for_per_host_no_stats.yaml', 'changelogs/fragments/43874-docker_container-stop_timeout.yaml', 'changelogs/fragments/44278-pamd_valid_simple_controls.yaml', 'changelogs/fragments/44789-docker_container-comparisons.yaml', 'changelogs/fragments/44988-acme-post-as-get.yaml', 'changelogs/fragments/45628-fetch_url-error-headers.yaml', 'changelogs/fragments/46322-docker_container-image-not-given.yaml', 'changelogs/fragments/46594-docker_container-publish-all-ports.yml', 'changelogs/fragments/46595-docker_container-expected_ports.yml', 'changelogs/fragments/46596-docker_container-published_ports.yml', 'changelogs/fragments/46598-docker_container-volume-modes.yml', 'changelogs/fragments/46658-plugin_filter-improve_error_handling.yaml', 'changelogs/fragments/46739-gcp-compute-instance-metadata.yaml', 'changelogs/fragments/46743-fix-native-jinja-newlines.yaml', 'changelogs/fragments/46772-docker_container-healthcheck.yaml', 'changelogs/fragments/46961_fix_aws_ec2_cache.yaml', 'changelogs/fragments/47247-docker_container-add-runtime-option.yaml', 'changelogs/fragments/47281-pamd-dont-delete-named_temporary_file_on_close.yaml', 'changelogs/fragments/47300-ios-check_rc.yaml', 'changelogs/fragments/47307-handler-include-task.yml', 'changelogs/fragments/47393-docker_image-id.yaml', 'changelogs/fragments/47395-docker_container-ipvX_address.yaml', 'changelogs/fragments/47396-docker_container-detach-auto-remove.yaml', 'changelogs/fragments/47500-rds_instance.yaml', 'changelogs/fragments/47689-yum-fix-version-syntax.yaml', 'changelogs/fragments/47704-apt-warn-auto-intall.yml', 'changelogs/fragments/47712-docker_container-detach-auto-remove.yml', 'changelogs/fragments/47722-vmware_guest_powerstate-restore_timeout.yaml', 'changelogs/fragments/47846-cs_ip_address-fix-vpc-vs-network.yaml', 'changelogs/fragments/47900-docker_container-paused.yml', 'changelogs/fragments/add-elapsed-return-value-to-select-modules.yaml', 'changelogs/fragments/agnostic-become-prompt.yaml', 'changelogs/fragments/ajson-nested-decode.yaml', 'changelogs/fragments/ansible-doc-fixes.yml', 'changelogs/fragments/async-dir.yaml', 'changelogs/fragments/async_statys_pyx_compat_fix.yml', 'changelogs/fragments/azure_rm_appgateway-probe.yaml', 'changelogs/fragments/azure_rm_deployment_fix_45941.yaml', 'changelogs/fragments/blockinfile-bytes-fix.yaml', 'changelogs/fragments/callback-keep-more-debug-keys.yml', 'changelogs/fragments/code-cleanup-no-get-exception.yaml', 'changelogs/fragments/command-stdin-no-newline.yaml', 'changelogs/fragments/copy-diff-text.yaml', 'changelogs/fragments/copy-recursive-remote-src.yml', 'changelogs/fragments/dd-put-empty-files.yaml', 'changelogs/fragments/delegate_to_loop_hostvars.yaml', 'changelogs/fragments/dnf-group-removal.yaml', 'changelogs/fragments/dnf-localgpgcheck.yaml', 'changelogs/fragments/dnfyum-disable-excludes.yaml', 'changelogs/fragments/docker-image-ids.yaml', 'changelogs/fragments/docker-swarm-service-defaults.yml', 'changelogs/fragments/docker_container-idempotency.yaml', 'changelogs/fragments/docker_volume-force-change-detection.yaml', 'changelogs/fragments/drop-pkg_resources.yaml', 'changelogs/fragments/ec2_asg-launch-template-support.yml', 'changelogs/fragments/ec2_group_fix_target_containing_list_within_list.yaml', 'changelogs/fragments/elb_target_group_fix_KeyError.yaml', 'changelogs/fragments/fix-password-lookup-on-fips.yaml', 'changelogs/fragments/fix_ec2_group_target_vpc_precedence.yaml', 'changelogs/fragments/fix_ec2_group_vpc_precedence_classic.yaml', 'changelogs/fragments/free-strategy-include-var-tags.yaml', 'changelogs/fragments/get-url-fix-idempotency.yaml', 'changelogs/fragments/get_url.yaml', 'changelogs/fragments/host-start-callback.yaml', 'changelogs/fragments/inv_fixes.yml', 'changelogs/fragments/k8s_facts_fix.yaml', 'changelogs/fragments/lineinfile-insertbefore-index-out-of-range.yaml', 'changelogs/fragments/loop-empty-literal-list.yaml', 'changelogs/fragments/loop_undefined_delegate_to.yaml', 'changelogs/fragments/macports-upgrade-selfupdate.yml', 'changelogs/fragments/mysql-migrate_to_pymysql.yaml', 'changelogs/fragments/no-mutable-fieldattribute-defaults.yaml', 'changelogs/fragments/no-overwrite-roles.yaml', 'changelogs/fragments/no_empty_groups.yml', 'changelogs/fragments/openssl-python3.yaml', 'changelogs/fragments/openstack_inventory_fix.yml', 'changelogs/fragments/ovirt_host_network_fix_type_conversion.yaml', 'changelogs/fragments/piped-transfer-empty-files.yaml', 'changelogs/fragments/plugin-docs-list-fix.yaml', 'changelogs/fragments/plugin-filters-cfg.yaml', 'changelogs/fragments/postgresql_user-not-sup-error.yaml', 'changelogs/fragments/psexec-handle-socket-errors.yaml', 'changelogs/fragments/psexec-imp-error.yaml', 'changelogs/fragments/psrp-utf8-stdio.yaml', 'changelogs/fragments/psrp-utf8.yaml', 'changelogs/fragments/reboot-show-timeout.yaml', 'changelogs/fragments/reboot-unicode-string.yaml', 'changelogs/fragments/reboot_missing_parameter.yaml', 'changelogs/fragments/reboot_openbsd_support.yaml', 'changelogs/fragments/remove_redundant_md5.yml', 'changelogs/fragments/restore_sigpipe_dfl.yml', 'changelogs/fragments/run-command-expand-shell.yaml', 'changelogs/fragments/s3_bucket_fix_non_str_tags.yaml', 'changelogs/fragments/script-module-no-file-path.yaml', 'changelogs/fragments/sns-boto3.yaml', 'changelogs/fragments/solaris-prtdiag-path.yaml', 'changelogs/fragments/tower_credential_ssh_key_data.yaml', 'changelogs/fragments/unsafe-set-wrap.yaml', 'changelogs/fragments/uri-supports-async.yaml', 'changelogs/fragments/user-do-not-pass-ssh_key_passphrase-on-cmdline.yaml', 'changelogs/fragments/user-docs-underlying-tools.yaml', 'changelogs/fragments/v2.8.0-initial-commit.yaml', 'changelogs/fragments/win_copy-dest-quote.yaml', 'changelogs/fragments/win_group_membership-com-marshal.yaml', 'changelogs/fragments/win_package_chdir.yaml', 'changelogs/fragments/win_say-fix.yaml', 'changelogs/fragments/win_scheduled_task-repetition.yaml', 'changelogs/fragments/win_script-become.yaml', 'changelogs/fragments/windows-deprecated-functionality.yaml', 'changelogs/fragments/windows-exec-changes.yaml', 'changelogs/fragments/windows-psrp-unreachable.yaml', 'changelogs/fragments/winrm_pexpect.yaml', 'changelogs/fragments/yumdnf-update-cache.yaml']' returned non-zero exit status 1.

click here for bot help

changelogs/fragments/k8s_facts_fix.yaml

ansibot · 2018-11-02T00:27:17Z

The test ansible-test sanity --test changelog [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/changelog.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "packaging/release/changelogs/changelog.py", line 814, in <module>
    main()
  File "packaging/release/changelogs/changelog.py", line 98, in main
    args.func(args)
  File "packaging/release/changelogs/changelog.py", line 109, in command_lint
    lint_fragments(fragments, exceptions)
  File "packaging/release/changelogs/changelog.py", line 227, in lint_fragments
    errors += linter.lint(fragment)
  File "packaging/release/changelogs/changelog.py", line 307, in lint
    errors += [(fragment.path, 0, 0, result[1]) for result in results]
  File "packaging/release/changelogs/changelog.py", line 307, in <listcomp>
    errors += [(fragment.path, 0, 0, result[1]) for result in results]
  File "/usr/local/lib/python3.6/dist-packages/rstcheck.py", line 169, in check
    find_ignored_languages(source)
  File "/usr/local/lib/python3.6/dist-packages/rstcheck.py", line 235, in find_ignored_languages
    for (index, line) in enumerate(source.splitlines()):
AttributeError: 'dict' object has no attribute 'splitlines'
Traceback (most recent call last):
  File "test/sanity/code-smell/changelog.py", line 14, in <module>
    main()
  File "test/sanity/code-smell/changelog.py", line 10, in main
    subprocess.check_call(cmd)
  File "/usr/lib/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['packaging/release/changelogs/changelog.py', 'lint', 'changelogs/fragments/2.8-core-deprecations.yaml', 'changelogs/fragments/2.8-removed-modules.yaml', 'changelogs/fragments/33754-docker_image_fix_changed_in_force_mode.yaml', 'changelogs/fragments/35370-add_support_for_docker_network_internal_flag.yaml', 'changelogs/fragments/42866-galaxy-search-unicode.yaml', 'changelogs/fragments/43123-add_support_for_per_host_no_stats.yaml', 'changelogs/fragments/43874-docker_container-stop_timeout.yaml', 'changelogs/fragments/44278-pamd_valid_simple_controls.yaml', 'changelogs/fragments/44789-docker_container-comparisons.yaml', 'changelogs/fragments/44988-acme-post-as-get.yaml', 'changelogs/fragments/45628-fetch_url-error-headers.yaml', 'changelogs/fragments/46322-docker_container-image-not-given.yaml', 'changelogs/fragments/46594-docker_container-publish-all-ports.yml', 'changelogs/fragments/46595-docker_container-expected_ports.yml', 'changelogs/fragments/46596-docker_container-published_ports.yml', 'changelogs/fragments/46598-docker_container-volume-modes.yml', 'changelogs/fragments/46658-plugin_filter-improve_error_handling.yaml', 'changelogs/fragments/46739-gcp-compute-instance-metadata.yaml', 'changelogs/fragments/46743-fix-native-jinja-newlines.yaml', 'changelogs/fragments/46772-docker_container-healthcheck.yaml', 'changelogs/fragments/46961_fix_aws_ec2_cache.yaml', 'changelogs/fragments/47247-docker_container-add-runtime-option.yaml', 'changelogs/fragments/47281-pamd-dont-delete-named_temporary_file_on_close.yaml', 'changelogs/fragments/47300-ios-check_rc.yaml', 'changelogs/fragments/47307-handler-include-task.yml', 'changelogs/fragments/47393-docker_image-id.yaml', 'changelogs/fragments/47395-docker_container-ipvX_address.yaml', 'changelogs/fragments/47396-docker_container-detach-auto-remove.yaml', 'changelogs/fragments/47492-docker_network-add-ipv6-support.yaml', 'changelogs/fragments/47500-rds_instance.yaml', 'changelogs/fragments/47689-yum-fix-version-syntax.yaml', 'changelogs/fragments/47704-apt-warn-auto-intall.yml', 'changelogs/fragments/47712-docker_container-detach-auto-remove.yml', 'changelogs/fragments/47722-vmware_guest_powerstate-restore_timeout.yaml', 'changelogs/fragments/47814-docker_container-device-io-limit-parameters.yaml', 'changelogs/fragments/47846-cs_ip_address-fix-vpc-vs-network.yaml', 'changelogs/fragments/47900-docker_container-paused.yml', 'changelogs/fragments/add-elapsed-return-value-to-select-modules.yaml', 'changelogs/fragments/agnostic-become-prompt.yaml', 'changelogs/fragments/ajson-nested-decode.yaml', 'changelogs/fragments/ansible-doc-fixes.yml', 'changelogs/fragments/async-dir.yaml', 'changelogs/fragments/async_statys_pyx_compat_fix.yml', 'changelogs/fragments/azure_rm_appgateway-probe.yaml', 'changelogs/fragments/azure_rm_deployment_fix_45941.yaml', 'changelogs/fragments/blockinfile-bytes-fix.yaml', 'changelogs/fragments/callback-keep-more-debug-keys.yml', 'changelogs/fragments/code-cleanup-no-get-exception.yaml', 'changelogs/fragments/command-stdin-no-newline.yaml', 'changelogs/fragments/copy-diff-text.yaml', 'changelogs/fragments/copy-recursive-remote-src.yml', 'changelogs/fragments/dd-put-empty-files.yaml', 'changelogs/fragments/delegate_to_loop_hostvars.yaml', 'changelogs/fragments/dnf-group-removal.yaml', 'changelogs/fragments/dnf-localgpgcheck.yaml', 'changelogs/fragments/dnfyum-disable-excludes.yaml', 'changelogs/fragments/docker-image-ids.yaml', 'changelogs/fragments/docker-swarm-service-defaults.yml', 'changelogs/fragments/docker_container-idempotency.yaml', 'changelogs/fragments/docker_network-requirements.yaml', 'changelogs/fragments/docker_volume-force-change-detection.yaml', 'changelogs/fragments/drop-pkg_resources.yaml', 'changelogs/fragments/ec2_asg-launch-template-support.yml', 'changelogs/fragments/ec2_group_fix_target_containing_list_within_list.yaml', 'changelogs/fragments/elb_target_group_fix_KeyError.yaml', 'changelogs/fragments/fix-password-lookup-on-fips.yaml', 'changelogs/fragments/fix_ec2_group_target_vpc_precedence.yaml', 'changelogs/fragments/fix_ec2_group_vpc_precedence_classic.yaml', 'changelogs/fragments/free-strategy-include-var-tags.yaml', 'changelogs/fragments/get-url-fix-idempotency.yaml', 'changelogs/fragments/get_url.yaml', 'changelogs/fragments/host-start-callback.yaml', 'changelogs/fragments/inv_fixes.yml', 'changelogs/fragments/k8s_facts_fix.yaml', 'changelogs/fragments/lineinfile-insertbefore-index-out-of-range.yaml', 'changelogs/fragments/loop-empty-literal-list.yaml', 'changelogs/fragments/loop_undefined_delegate_to.yaml', 'changelogs/fragments/macports-upgrade-selfupdate.yml', 'changelogs/fragments/mysql-migrate_to_pymysql.yaml', 'changelogs/fragments/no-mutable-fieldattribute-defaults.yaml', 'changelogs/fragments/no-overwrite-roles.yaml', 'changelogs/fragments/no_empty_groups.yml', 'changelogs/fragments/openssl-python3.yaml', 'changelogs/fragments/openstack_inventory_fix.yml', 'changelogs/fragments/ovirt_host_network_fix_type_conversion.yaml', 'changelogs/fragments/piped-transfer-empty-files.yaml', 'changelogs/fragments/plugin-docs-list-fix.yaml', 'changelogs/fragments/plugin-filters-cfg.yaml', 'changelogs/fragments/postgresql_user-not-sup-error.yaml', 'changelogs/fragments/psexec-handle-socket-errors.yaml', 'changelogs/fragments/psexec-imp-error.yaml', 'changelogs/fragments/psrp-utf8-stdio.yaml', 'changelogs/fragments/psrp-utf8.yaml', 'changelogs/fragments/reboot-show-timeout.yaml', 'changelogs/fragments/reboot-unicode-string.yaml', 'changelogs/fragments/reboot_missing_parameter.yaml', 'changelogs/fragments/reboot_openbsd_support.yaml', 'changelogs/fragments/remove_redundant_md5.yml', 'changelogs/fragments/restore_sigpipe_dfl.yml', 'changelogs/fragments/run-command-expand-shell.yaml', 'changelogs/fragments/s3_bucket_fix_non_str_tags.yaml', 'changelogs/fragments/s3_bucket_requester_pays_default_value.yaml', 'changelogs/fragments/s3_bucket_walrus_endpoint.yaml', 'changelogs/fragments/script-module-no-file-path.yaml', 'changelogs/fragments/sns-boto3.yaml', 'changelogs/fragments/solaris-prtdiag-path.yaml', 'changelogs/fragments/tower_credential_ssh_key_data.yaml', 'changelogs/fragments/unsafe-set-wrap.yaml', 'changelogs/fragments/uri-supports-async.yaml', 'changelogs/fragments/user-do-not-pass-ssh_key_passphrase-on-cmdline.yaml', 'changelogs/fragments/user-docs-underlying-tools.yaml', 'changelogs/fragments/v2.8.0-initial-commit.yaml', 'changelogs/fragments/win_copy-dest-quote.yaml', 'changelogs/fragments/win_group_membership-com-marshal.yaml', 'changelogs/fragments/win_package_chdir.yaml', 'changelogs/fragments/win_say-fix.yaml', 'changelogs/fragments/win_scheduled_task-repetition.yaml', 'changelogs/fragments/win_script-become.yaml', 'changelogs/fragments/windows-deprecated-functionality.yaml', 'changelogs/fragments/windows-exec-changes.yaml', 'changelogs/fragments/windows-psrp-unreachable.yaml', 'changelogs/fragments/winrm_pexpect.yaml', 'changelogs/fragments/yumdnf-update-cache.yaml']' returned non-zero exit status 1.

click here for bot help

maxamillion · 2018-11-02T19:41:36Z

shipit

mkrizek · 2018-11-06T11:34:44Z

rebuild_merge

(cherry picked from commit a5c8e95)

ansibot removed the needs_triage Needs a first human triage before being processed. label Oct 31, 2018

Akasurde requested review from willthames and Akasurde October 31, 2018 15:19

mmazur force-pushed the k8s_facts_fix branch from 3e01fc3 to fea5311 Compare October 31, 2018 15:29

Akasurde approved these changes Oct 31, 2018

View reviewed changes

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 31, 2018

willthames suggested changes Nov 1, 2018

View reviewed changes

changelogs/fragments/k8s_facts_fix.yaml Outdated Show resolved Hide resolved

mmazur force-pushed the k8s_facts_fix branch from fea5311 to c2f49a6 Compare November 1, 2018 12:39

willthames approved these changes Nov 1, 2018

View reviewed changes

willthames reviewed Nov 2, 2018

View reviewed changes

changelogs/fragments/k8s_facts_fix.yaml Outdated Show resolved Hide resolved

k8s_facts: fix handling of unknown resource types

c7336ee

mmazur force-pushed the k8s_facts_fix branch from c2f49a6 to c7336ee Compare November 2, 2018 08:58

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 2, 2018

mkrizek merged commit a5c8e95 into ansible:devel Nov 6, 2018

Akasurde pushed a commit to Akasurde/ansible that referenced this pull request Nov 12, 2018

k8s_facts: fix handling of unknown resource types (ansible#47857)

69415c5

(cherry picked from commit a5c8e95)

abadger pushed a commit that referenced this pull request Nov 13, 2018

k8s_facts: fix handling of unknown resource types (#47857)

642cd53

(cherry picked from commit a5c8e95)

mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018

k8s_facts: fix handling of unknown resource types (ansible#47857)

a0ae307

Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018

k8s_facts: fix handling of unknown resource types (ansible#47857)

39f6b87

ansible locked and limited conversation to collaborators Jul 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

k8s_facts: fix handling of unknown resource types #47857

k8s_facts: fix handling of unknown resource types #47857

mmazur commented Oct 31, 2018

ansibot commented Oct 31, 2018

ansibot commented Oct 31, 2018

willthames commented Oct 31, 2018

willthames commented Oct 31, 2018

willthames commented Oct 31, 2018

mmazur commented Oct 31, 2018

Akasurde commented Oct 31, 2018

mmazur commented Oct 31, 2018

Akasurde left a comment

ansibot commented Nov 1, 2018

ansibot commented Nov 2, 2018

maxamillion commented Nov 2, 2018

mkrizek commented Nov 6, 2018

k8s_facts: fix handling of unknown resource types #47857

k8s_facts: fix handling of unknown resource types #47857

Conversation

mmazur commented Oct 31, 2018

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented Oct 31, 2018

ansibot commented Oct 31, 2018

willthames commented Oct 31, 2018

willthames commented Oct 31, 2018

willthames commented Oct 31, 2018

mmazur commented Oct 31, 2018

Akasurde commented Oct 31, 2018

mmazur commented Oct 31, 2018

Akasurde left a comment

Choose a reason for hiding this comment

ansibot commented Nov 1, 2018

ansibot commented Nov 2, 2018

maxamillion commented Nov 2, 2018

mkrizek commented Nov 6, 2018