Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct yum and dnf autoremove behavior #47902

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Correct yum and dnf autoremove behavior #47902

merged 2 commits into from
Nov 5, 2018

Conversation

maxamillion
Copy link
Contributor

Signed-off-by: Adam Miller admiller@redhat.com

SUMMARY

Sanity check args passed to autoremove

Fixes #47184

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yum
dnf

ANSIBLE VERSION
ansible 2.8.0.dev0 (issue/47184-dnf-yum-autoremove-not-as-documented 99866f167d) last updated 2018/10/31 17:08:53 (GMT -500)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/admiller/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/admiller/src/dev/ansible/lib/ansible
  executable location = /home/admiller/src/dev/ansible/bin/ansible
  python version = 2.7.15 (default, Oct 15 2018, 15:24:06) [GCC 8.1.1 20180712 (Red Hat 8.1.1-5)]

@maxamillion
Correct yum and dnf autoremove behavior
99866f1 
Sanity check args passed to autoremove

Fixes ansible#47184

Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion maxamillion added the affects_2.7 This issue/PR affects Ansible v2.7 label Oct 31, 2018
@maxamillion
Copy link
Contributor Author

As a note: I did want to add an integration test, but this modifies the CI environment in unpredictable ways so I don't know how I'd roll it back in order to not fail the final "you changed something in the test environment" check. I'm open to clever ideas on how to do it. :)

@ansibot
Copy link
Contributor

ansibot commented Oct 31, 2018

Hi @maxamillion, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 31, 2018

cc @Akasurde @berenddeschouwer @kustodian @verm666
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 31, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 31, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/packaging/os/dnf.py:0:0: E324 Value for "default" from the argument_spec (None) for "state" does not match the documentation ('None')

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 31, 2018
@mkrizek
Copy link
Contributor

mkrizek commented Nov 1, 2018

This looks good to me. Not sure what to do with the sanity test failure though.

@maxamillion
fix docs
6d4bcee 
Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Nov 1, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 1, 2018
@maxamillion
Copy link
Contributor Author

rebuild_merge

@ansibot ansibot merged commit 1c77797 into ansible:devel Nov 5, 2018
maxamillion added a commit to maxamillion/ansible that referenced this pull request Nov 5, 2018
@maxamillion
Correct yum and dnf autoremove behavior (ansible#47902)
8801d5a 
* Correct yum and dnf autoremove behavior

Sanity check args passed to autoremove

Fixes ansible#47184

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix docs

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 1c77797)
abadger pushed a commit that referenced this pull request Nov 5, 2018
@maxamillion @abadger
Correct yum and dnf autoremove behavior (#47902)
3a14fe3 
* Correct yum and dnf autoremove behavior

Sanity check args passed to autoremove

Fixes #47184

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix docs

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 1c77797)
@maxamillion maxamillion mentioned this pull request Nov 14, 2018
Merged
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@maxamillion @mjmayer
Correct yum and dnf autoremove behavior (ansible#47902)
59eccec 
* Correct yum and dnf autoremove behavior

Sanity check args passed to autoremove

Fixes ansible#47184

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix docs

Signed-off-by: Adam Miller <admiller@redhat.com>
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@maxamillion @Tomorrow9
Correct yum and dnf autoremove behavior (ansible#47902)
0b46139 
* Correct yum and dnf autoremove behavior

Sanity check args passed to autoremove

Fixes ansible#47184

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix docs

Signed-off-by: Adam Miller <admiller@redhat.com>
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

@kustodian kustodian kustodian approved these changes

@abadger abadger Awaiting requested review from abadger

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dnf: autoremove is not working as documented in ansible 2.7.0
5 participants
@maxamillion @ansibot @mkrizek @kustodian @dagwieers