remove obsolete set_play on play_context

[bcoca]

• all tasks already inherit this from play directly

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

play_context

ANSIBLE VERSION

2.x

[ansibot]

Hi @bcoca, thank you for submitting this pull-request!

click here for bot help

[mattclay]

CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/92808/5/tests

[felixfontein]

@bcoca Every playbook I'm executing now is currently littered with [DEPRECATION WARNING]: PlayContext.force_handlers should not be used, the calling code should be using play itself instead. This feature will be removed in version 2.19. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. warnings (which have been introduced in this PR). I'm even getting it with a trivial playbook such as:

- hosts: localhost
  tasks: []

Is this intended?

[albers]

I'm also facing this in a slightly different context:

A playbook with several plays.
The first play invokes a role that calls another role from its task file via include_role (also happens with import_role).
Every task in that secondary role causes the deprecation warning.

playbook

# This play causes lots of deprecation warnings
- name: Create VMs
  hosts: swarm_masters
  gather_facts: no
  tags: [deploy]
  roles:
    - ubuntu_cloud_image_host

# This play does not cause any deprecation warnings
- name: Create a Docker swarm
  hosts: swarm_masters
  tags: [swarm]
  roles:
    - ubuntu_host
    - swarm_master

tasks file of role ubuntu_cloud_image_host

- import_role: name=albers.vmware_ubuntu_cloud_image

[felixfontein]

@albers the problem I had was fixed in #53705; do you still have this problem after that PR was merged?

[albers]

@felixfontein Thanks for the hint.

I was still at 15303b0.
Pulling to the current repo state (fa2e8d8) resolved the issue for me.