Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldap_attr bugfix #48009

Merged
merged 1 commit into from
Nov 5, 2018
Merged

ldap_attr bugfix #48009

merged 1 commit into from
Nov 5, 2018

Conversation

Flakebi
Copy link
Contributor

@Flakebi Flakebi commented Nov 2, 2018

SUMMARY

Similar to #46818, this fixes an error when using multiple values with ldap_attr.
The error is TypeError: object of type 'map' has no len().

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ldap_attr

ANSIBLE VERSION
2.7

@ansibot
Copy link
Contributor

ansibot commented Nov 2, 2018

Hi @Flakebi, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 2, 2018

cc @jtyr
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Nov 2, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Nov 2, 2018
@Shaps
Copy link
Contributor

Shaps commented Nov 5, 2018

shipit

@gundalow gundalow merged commit ee13bc2 into ansible:devel Nov 5, 2018
@gundalow
Copy link
Contributor

gundalow commented Nov 5, 2018

@Flakebi Thank you for this bug fix, your first I believe! Welcome to the Ansible community

@jtyr @Shaps Thank you for the review.

Merged into devel for release in Ansible 2.8. I'll raise a backport for 2.7

gundalow pushed a commit to gundalow/ansible that referenced this pull request Nov 5, 2018
@Flakebi @gundalow
ldap_attr bugfix (ansible#48009)
270e946 
(cherry picked from commit ee13bc2)
abadger pushed a commit that referenced this pull request Nov 5, 2018
@gundalow @abadger
ldap_attr bugfix (#48009) (#48106)
9ac8763 
* ldap_attr bugfix (#48009)

(cherry picked from commit ee13bc2)

* changelog
@Flakebi Flakebi deleted the ldap_attr branch November 5, 2018 19:12
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@Flakebi @mjmayer
ldap_attr bugfix (ansible#48009)
54745c4
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@Flakebi @Tomorrow9
ldap_attr bugfix (ansible#48009)
98aa7e0
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtyr jtyr jtyr approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. net_tools Net-tools category new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Flakebi @ansibot @Shaps @gundalow @jtyr