Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_network: fix idempotency test #48038

Merged
merged 1 commit into from
Nov 5, 2018
Merged

docker_network: fix idempotency test #48038

merged 1 commit into from
Nov 5, 2018

Conversation

felixfontein
Copy link
Contributor

SUMMARY

The connection-to-containers idempotency test was failing because the containers were not actually running, but just created... This fixes the tests and uncomments the problematic parts which failed before.

CC @DBendit

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_network

ANSIBLE VERSION
2.8.0

@ansibot
Copy link
Contributor

ansibot commented Nov 3, 2018

Hi @felixfontein, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 3, 2018

cc @akshay196 @chouseknecht @danihodovic @dariko @jwitko @kassiansun @keitwb @olsaki @tbouvet
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Nov 3, 2018
@akshay196
Copy link
Contributor

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Nov 5, 2018
@gundalow gundalow merged commit 8eb656d into ansible:devel Nov 5, 2018
@gundalow
Copy link
Contributor

gundalow commented Nov 5, 2018

@felixfontein Thanks for spotting and fixing this,

@akshay196 Thank you for your review

felixfontein added a commit to felixfontein/ansible that referenced this pull request Nov 5, 2018
@felixfontein
Fixing idempotency test. (ansible#48038)
ec1913d 
(cherry picked from commit 8eb656d)
@felixfontein felixfontein mentioned this pull request Nov 5, 2018
Merged
@felixfontein felixfontein deleted the docker_network-idempotency branch November 5, 2018 16:40
abadger pushed a commit that referenced this pull request Nov 5, 2018
@felixfontein @abadger
Fixing idempotency test. (#48038)
eef35f1 
(cherry picked from commit 8eb656d)
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@felixfontein @mjmayer
Fixing idempotency test. (ansible#48038)
9a66b54
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@felixfontein @Tomorrow9
Fixing idempotency test. (ansible#48038)
d16e80e
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud docker shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibot @akshay196 @gundalow