docker_container: improve tests to avoid spurious test fails #48059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @felixfontein, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
ansibot
added
shipit
|
@kassiansun thanks! Can you also take a look at #48056 and #48061? They fix some details about docker_container which are also pretty annoying during tests :) |
|
@kassiansun thanks for reviewing! |
|
Backport included in #47831. |
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Nov 5, 2018
abadger
pushed a commit
that referenced
this pull request
Nov 5, 2018
mjmayer
pushed a commit
to mjmayer/ansible
that referenced
this pull request
Nov 30, 2018
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Sometimes, the docker_container tests are unstable because the
detach: notest behaves strangely (Outputdoes not contain the output expected fromhello-world). While we have no idea why this happens and cannot reproduce it properly, it happens often enough to justify changing the test so that it simply checks forOutputto be present, instead ofOutputcontaining a specific text.Fixes #47896.
ISSUE TYPE
COMPONENT NAME
docker_container
ANSIBLE VERSION