Adjust pause integration test for interactive and echo sceanrio #48125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use send() rather than sendlin() calls when testing interactive prompting and echo.
|
Hi @samdoran, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
samdoran
removed
the
needs_triage
mjmayer
pushed a commit
to mjmayer/ansible
that referenced
this pull request
Nov 30, 2018
Use send() rather than sendlin() calls when testing interactive prompting and echo.
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
Use send() rather than sendlin() calls when testing interactive prompting and echo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use
send()rather thansendline()calls when testing interactive prompting and echo. This makes the tests work properly with @jimi-c's threading and forking split branch.ISSUE TYPE
COMPONENT NAME
test/integration/targets/pause/test-pause.pyANSIBLE VERSION