Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP Bug & feature Fixes #48276

Merged
merged 2 commits into from Nov 15, 2018
Merged

GCP Bug & feature Fixes #48276

merged 2 commits into from Nov 15, 2018

Conversation

rambleraptor
Copy link
Contributor

@rambleraptor rambleraptor commented Nov 6, 2018 •
edited by gundalow

SUMMARY

This mostly does documentation formatting and a couple issue fixes.

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

gcp_*

ANSIBLE VERSION
2.8
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Nov 6, 2018

Hi @rambleraptor, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 6, 2018
@gundalow gundalow removed needs_triage Needs a first human triage before being processed. labels Nov 6, 2018
@gundalow gundalow self-assigned this Nov 6, 2018
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Nov 6, 2018
gundalow
gundalow reviewed Nov 7, 2018
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Majority of this PR seems to be whitespace changes which makes it difficult to review the functional change in this PR.

Are the whitespace changes actually needed?

I assume this has run though all your local test, so this should be safe to merge into devel as is?

lib/ansible/modules/cloud/google/gcp_compute_address.py
the following values: PREMIUM or STANDARD. If this field is not specified, it
is assumed to be PREMIUM.'
required: false
version_added: 2.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've added new features here, so this is a feature PR, so can't backport it

@rambleraptor
Copy link
Contributor Author

We changed the way we created the documentation on Magic Modules which makes it a lot easier for us (we weren't using a YAML parser to build documentation in the past). The side effect is that there's a bunch of one-time whitespace changes.

We won't be able to keep the Magic Modules code generator up-to-date with the Ansible codebase without getting the whitespace changes in.

What can I do to make this easier to review?

@gundalow gundalow merged commit 5ad5677 into ansible:devel Nov 15, 2018
@gundalow gundalow changed the title GCP Bug Fixes GCP Bug & feature Fixes Nov 15, 2018
@gundalow gundalow added the feature This issue/PR relates to a feature request. label Nov 15, 2018
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@rambleraptor @mjmayer
GCP Bug Fixes (ansible#48276)
4a32f97 
* GCP Bug fixes

* added util file changes
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@rambleraptor @Tomorrow9
GCP Bug Fixes (ansible#48276)
deeda92 
* GCP Bug fixes

* added util file changes
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

Assignees

@gundalow gundalow

Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. gce needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rambleraptor @ansibot @gundalow