Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meraki_vlan - Add note explaining VLAN support tests in a Meraki network #48278

Merged
merged 2 commits into from
Nov 7, 2018
Merged

meraki_vlan - Add note explaining VLAN support tests in a Meraki network #48278

merged 2 commits into from
Nov 7, 2018

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Nov 6, 2018

SUMMARY

Simply add a note explaining how to know if VLAN support is enabled on a network. Another PR will be submitted to allow the meraki_network module to enable VLAN support.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

meraki_vlan

ANSIBLE VERSION

2.8

@ansibot
Copy link
Contributor

ansibot commented Nov 6, 2018

Hi @kbreit, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 6, 2018

cc @dagwieers
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. meraki Cisco Meraki community module This issue/PR relates to a module. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 6, 2018
@dagwieers dagwieers merged commit 74619c2 into ansible:devel Nov 7, 2018
@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Nov 7, 2018
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@kbreit @mjmayer
meraki_vlan - Add note explaining VLAN support tests in a Meraki netw…
9adb78a 
…ork (ansible#48278)

* Add note explaining VLAN support tests in a Meraki network

* Small fix.
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@kbreit @Tomorrow9
meraki_vlan - Add note explaining VLAN support tests in a Meraki netw…
51c0ad5 
…ork (ansible#48278)

* Add note explaining VLAN support tests in a Meraki network

* Small fix.
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
@kbreit kbreit deleted the meraki/vlan_check_note branch November 28, 2019 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kbreit @ansibot @dagwieers @bcoca