Backport/2.7/47695 - pamd fixes #48307
Conversation
* Providing fix for #47083 in pamd.py * Providing fix for #47197 * Fixing pep8 errors * update regex to account for leading dash and VALID_TYPES with dashes as well * use a results dictionary and clean up unnecessary items * remove unnessecary return value. action is already reported in invocation output * make naming consistent across action returns * fix comparison so it checks equality instead of identity and indentation in update_rule() * make sure file always has EOF newline * updated regex to skip spacing between path and args and add rule arg regex to capture complex args * new module argument parsing code in function and DRY changes * remove unused has_rule method on PamdService class * fix error in parse_module_arguments() * updated args_present action to make it handle key value args and fail on complex bracketed arguments * pep8 and other fixes so units still work * suggested change - make version removed 2.8 Co-Authored-By: shepdelacreme <shepdelacreme@users.noreply.github.com> * add more error proof test to if statement (cherry picked from commit ef690e9)
|
Hi @shepdelacreme, thank you for submitting this pull-request! |
ansibot
added
affects_2.7
|
shipit |
jborean93
removed
the
needs_triage
|
|
|
Ah ok...I was under the impression that since this module is in |
|
API parameters may change between major releases (2.6.x => 2.7.x), even without a deprecation notice if the status is preview (although we discourage that, especially if the module is popular ;-). Within a major release series (2.7.x), the API needs to stay backwards compatible. That way users can anticipate playbook breakage on major release boundaries, not on bugfix upgrades. |
ansibot
removed
the
needs_maintainer
|
Ah ok makes sense! I will add that back in and update the changelog fragment shortly! |
|
Merged for the 2.7.2 release |
SUMMARY
Backport of pamd module fixes in #47695
-is valid at beginning of _type_ #47418(cherry picked from commit ef690e9)
ISSUE TYPE
COMPONENT NAME
pamd
ANSIBLE VERSION
ADDITIONAL INFORMATION