Vultr server gather facts fails when firewall is enabled on a VM

[cleming]

SUMMARY

vultr_server_facts fails when a VM has a firewall enabled. Works normally without firewall.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vultr_server_facts

ANSIBLE VERSION

ansible 2.7.0

ADDITIONAL INFORMATION

vultr_server_facts with firewall on VM before change:

The full traceback is:
Traceback (most recent call last):
  File "<stdin>", line 113, in <module>
  File "<stdin>", line 105, in _ansiballz_main
  File "<stdin>", line 48, in invoke_module
  File "/tmp/ansible_vultr_server_facts_payload_EYlPlh/__main__.py", line 188, in <module>
  File "/tmp/ansible_vultr_server_facts_payload_EYlPlh/__main__.py", line 180, in main
  File "/tmp/ansible_vultr_server_facts_payload_EYlPlh/ansible_vultr_server_facts_payload.zip/ansible/module_utils/vultr.py", line 268, in get_result
  File "/tmp/ansible_vultr_server_facts_payload_EYlPlh/ansible_vultr_server_facts_payload.zip/ansible/module_utils/vultr.py", line 250, in normalize_result
ValueError: invalid literal for int() with base 10: '8950f8b6'

fatal: [localhost -> localhost]: FAILED! => {
    "changed": false, 
    "module_stderr": "Traceback (most recent call last):\n  File \"<stdin>\", line 113, in <module>\n  File \"<stdin>\", line 105, in _ansiballz_main\n  File \"<stdin>\", line 48, in invoke_module\n  File \"/tmp/ansible_vultr_server_facts_payload_EYlPlh/__main__.py\", line 188, in <module>\n  File \"/tmp/ansible_vultr_server_facts_payload_EYlPlh/__main__.py\", line 180, in main\n  File \"/tmp/ansible_vultr_server_facts_payload_EYlPlh/ansible_vultr_server_facts_payload.zip/ansible/module_utils/vultr.py\", line 268, in get_result\n  File \"/tmp/ansible_vultr_server_facts_payload_EYlPlh/ansible_vultr_server_facts_payload.zip/ansible/module_utils/vultr.py\", line 250, in normalize_result\nValueError: invalid literal for int() with base 10: '8950f8b6'\n", 
    "module_stdout": "", 
    "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", 
    "rc": 1
}

after change: works great.

[ansibot]

Hi @cleming, thank you for submitting this pull-request!

click here for bot help

[ansibot]

cc @Spredzy @resmo
click here for bot help

[resmo]

shipit

[resmo]

good catch, thanks.

[resmo]

bot_status

[ansibot]

Components

lib/ansible/modules/cloud/vultr/vultr_server_facts.py
support: community
maintainers: Spredzy resmo

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): resmo
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

[resmo]

Thanks!

[resmo]

backport PR for 2.7.x #48563