Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Backport) ec2_instance, ebs_optimized not sub-option of network #48467

Merged
merged 3 commits into from
Nov 13, 2018
Merged

(Backport) ec2_instance, ebs_optimized not sub-option of network #48467

merged 3 commits into from
Nov 13, 2018

Conversation

Shaps
Copy link
Contributor

@Shaps Shaps commented Nov 10, 2018

SUMMARY

Backporting changes from #48341

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_instance.py

ANSIBLE VERSION

N/A

ADDITIONAL INFORMATION

N/A

@Shaps
ec2_instance: ebs_optimized is not sub-option of 'network' (ansible#4…
4b53b18 
…8341)

* ebs_optimized is not suboption of 'network'

* Add Shaps as ec2_instance maintainer

* Added workaround-backward compatible check for ebs_optimized

* Added ebs_optimized test

* CI fixes, dynamic select of ENA-enabled AMI

(cherry picked from commit b7d9feb)
@ansibot
Copy link
Contributor

ansibot commented Nov 10, 2018

Hi @Shaps, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 10, 2018

cc @ryansb
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. labels Nov 10, 2018
@ansibot ansibot added cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 10, 2018

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/48341-ebs-optimized-ec2-instance.yaml:0:0: yaml parsing error

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

changelogs/fragments/48341-ebs-optimized-ec2-instance.yaml:2:19: error syntax error: sequence entries are not allowed here

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 10, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 10, 2018
@abadger abadger merged commit 50e6361 into ansible:stable-2.7 Nov 13, 2018
@abadger
Copy link
Contributor

abadger commented Nov 13, 2018

Merged for the 2.7.2 release.

@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Nov 13, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shaps @ansibot @abadger @bcoca