Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds bigip_dns_nameserver module #48480

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Adds bigip_dns_nameserver module #48480

merged 1 commit into from
Nov 10, 2018

Conversation

caphrim007
Copy link
Contributor

SUMMARY

This module can be used to manage DNS nameservers (usually used for
DNS express) functionality on a BIG-IP.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

bigip_dns_nameserver

ANSIBLE VERSION
ansible 2.8.0.dev0
  config file = None
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.7 (default, Oct 24 2018, 22:47:56) [GCC 6.3.0 20170516]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Nov 10, 2018

Hi @caphrim007, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Nov 10, 2018
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Nov 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 10, 2018

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

lib/ansible/modules/network/f5/bigip_dns_nameserver.py:405:21: undefined-variable Undefined variable 'response'
lib/ansible/modules/network/f5/bigip_dns_nameserver.py:405:34: undefined-variable Undefined variable 'response'
lib/ansible/modules/network/f5/bigip_dns_nameserver.py:406:28: undefined-variable Undefined variable 'response'
lib/ansible/modules/network/f5/bigip_dns_nameserver.py:407:36: undefined-variable Undefined variable 'response'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 10, 2018
@caphrim007
Adds bigip_dns_nameserver module
781cf5e 
This module can be used to manage DNS nameservers (usually used for
DNS express) functionality on a BIG-IP.
@caphrim007 caphrim007 force-pushed the feature.add-bigip-dns-nameserver-module branch from 7776399 to 781cf5e Compare November 10, 2018 20:37
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 10, 2018
@caphrim007 caphrim007 merged commit b5ee96a into ansible:devel Nov 10, 2018
Ghilli3 pushed a commit to Ghilli3/ansible that referenced this pull request Nov 12, 2018
@caphrim007 @Ghilli3
Adds bigip_dns_nameserver module (ansible#48480)
c158e24 
This module can be used to manage DNS nameservers (usually used for
DNS express) functionality on a BIG-IP.
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@caphrim007 @mjmayer
Adds bigip_dns_nameserver module (ansible#48480)
c81eb1f 
This module can be used to manage DNS nameservers (usually used for
DNS express) functionality on a BIG-IP.
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@caphrim007 @Tomorrow9
Adds bigip_dns_nameserver module (ansible#48480)
25fb6f1 
This module can be used to manage DNS nameservers (usually used for
DNS express) functionality on a BIG-IP.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caphrim007 @ansibot