Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move _handle_no_log_values() out of basic.py #48628

Merged
merged 12 commits into from
Mar 4, 2019
Merged

Move _handle_no_log_values() out of basic.py #48628

merged 12 commits into from
Mar 4, 2019

Conversation

samdoran
Copy link
Contributor

SUMMARY

Part of the work to enable controller side arg spec parsing/validation.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/module_utils/basic.py
lib/ansible/module_utils/common/parameters.py

ANSIBLE VERSION
2.8

@samdoran samdoran force-pushed the arg_spec/handle_no_log_values branch from bc8122a to a33374d Compare November 13, 2018 22:21
@ansibot
Copy link
Contributor

ansibot commented Nov 13, 2018

Hi @samdoran, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 13, 2018
@mattclay
Copy link
Member

CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/93922/8/tests

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Nov 16, 2018
@samdoran samdoran changed the title Move _handle_log_values() out of basic.py Move _handle_no_log_values() out of basic.py Nov 19, 2018
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed ci_verified Changes made in this PR are causing tests to fail. labels Nov 19, 2018
@sivel sivel removed needs_triage Needs a first human triage before being processed. labels Nov 20, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Nov 20, 2018
@samdoran samdoran force-pushed the arg_spec/handle_no_log_values branch from 667d27c to 660b3d6 Compare November 21, 2018 16:25
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Nov 21, 2018
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Feb 28, 2019
@samdoran samdoran force-pushed the arg_spec/handle_no_log_values branch from c5b8da6 to 062590e Compare February 28, 2019 22:29
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Feb 28, 2019
@ansibot

This comment has been minimized.

Sign in to view
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 28, 2019
@samdoran samdoran force-pushed the arg_spec/handle_no_log_values branch from 79da5bf to 12c9750 Compare March 1, 2019 19:19
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 1, 2019
sivel
sivel requested changes Mar 4, 2019
View reviewed changes
lib/ansible/module_utils/basic.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 4, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 4, 2019
@samdoran samdoran merged commit aba4bed into ansible:devel Mar 4, 2019
@samdoran samdoran deleted the arg_spec/handle_no_log_values branch March 4, 2019 22:02
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger abadger left review comments

@sivel sivel sivel approved these changes

@Qalthos Qalthos Qalthos approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aireos Cisco AireOS community asa Cisco ASA community cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. networking Network category nxos Cisco NXOS community support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@samdoran @ansibot @mattclay @abenokraitis @sivel @abadger @Qalthos @dagwieers @acozine