Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better handling of bad type in config #48821

Merged
merged 3 commits into from
Nov 19, 2018
Merged

better handling of bad type in config #48821

merged 3 commits into from
Nov 19, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Nov 16, 2018

fixes #22468, fixes #22476

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

config

@ansibot
Copy link
Contributor

ansibot commented Nov 16, 2018

Hi @bcoca, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 16, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 16, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 16, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Nov 17, 2018
@ansible ansible deleted a comment from ansibot Nov 19, 2018
@bcoca bcoca merged commit 87e44a7 into ansible:devel Nov 19, 2018
@bcoca bcoca deleted the fix_empty_envvar_int branch November 19, 2018 16:45
bcoca added a commit to bcoca/ansible that referenced this pull request Nov 19, 2018
@bcoca
better handling of bad type in config (ansible#48821)
633cfa5 
* better handling of bad type in config

 fixes ansible#22468, fixes ansible#22476


(cherry picked from commit 87e44a7)
abadger pushed a commit that referenced this pull request Nov 19, 2018
@bcoca @abadger
better handling of bad type in config (#48821)
1469ec4 
* better handling of bad type in config

 fixes #22468, fixes #22476


(cherry picked from commit 87e44a7)
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@bcoca @mjmayer
better handling of bad type in config (ansible#48821)
da005fb 
* better handling of bad type in config

 fixes ansible#22468, fixes ansible#22476
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@bcoca @Tomorrow9
better handling of bad type in config (ansible#48821)
0a022b7 
* better handling of bad type in config

 fixes ansible#22468, fixes ansible#22476
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ANSIBLE_VERBOSITY= ansible causes TypeError traceback
4 participants
@bcoca @ansibot @samdoran @Akasurde