Reboot - Fix errors when using Paramiko connection #49002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @samdoran, thank you for submitting this pull-request! |
ansibot
added
WIP
samdoran
force-pushed
the
issue/48948-reboot-paramiko
branch
from
8ceedb4
to
0ebcc2f
Compare
ansibot
added
support:core
samdoran
force-pushed
the
issue/48948-reboot-paramiko
branch
from
0ebcc2f
to
bb5d537
Compare
samdoran
changed the title
Different connection plugins return different data when throwing exceptions. The Paramiko connection plugin does not return a text sting, which caused an exception. The ssh connection plugin returns multi-line errors, which makes the debug logs harder to read. Only return the last line in that case in order to make the logs more readable. When experiencing a connection failure, reset the connection. Co-authored-by: Matt Martz <matt@sivel.net>
Indicate thet conection state is False when running close(). This is neede by the ensure_connected() decorator to work properly.
samdoran
force-pushed
the
issue/48948-reboot-paramiko
branch
from
bb5d537
to
d81f392
Compare
ansibot
added
core_review
manuBocquet
approved these changes
Nov 22, 2018
|
Hi, I did a test this morning. And your fixe solved the problem. Thanks. |
ansibot
removed
the
support:community
abadger
removed
the
needs_triage
bcoca
approved these changes
Nov 27, 2018
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Nov 27, 2018
…ble#49002) Different connection plugins return different data when throwing exceptions. The Paramiko connection plugin does not return a text sting, which caused an exception. The ssh connection plugin returns multi-line errors, which makes the debug logs harder to read. Only return the last line in that case in order to make the logs more readable. When experiencing a connection failure, reset the connection. Add reset() to paramiko_ssh Indicate thet conection state is False when running close(). This is needed by the ensure_connected() decorator to work properly. Co-authored-by: Matt Martz <matt@sivel.net> (cherry picked from commit 5eb7f57) Co-authored-by: Sam Doran <sdoran@redhat.com>
mjmayer
pushed a commit
to mjmayer/ansible
that referenced
this pull request
Nov 30, 2018
Different connection plugins return different data when throwing exceptions. The Paramiko connection plugin does not return a text sting, which caused an exception. The ssh connection plugin returns multi-line errors, which makes the debug logs harder to read. Only return the last line in that case in order to make the logs more readable. When experiencing a connection failure, reset the connection. Add reset() to paramiko_ssh Indicate thet conection state is False when running close(). This is needed by the ensure_connected() decorator to work properly. Co-authored-by: Matt Martz <matt@sivel.net>
abadger
pushed a commit
that referenced
this pull request
Dec 4, 2018
Different connection plugins return different data when throwing exceptions. The Paramiko connection plugin does not return a text sting, which caused an exception. The ssh connection plugin returns multi-line errors, which makes the debug logs harder to read. Only return the last line in that case in order to make the logs more readable. When experiencing a connection failure, reset the connection. Add reset() to paramiko_ssh Indicate thet conection state is False when running close(). This is needed by the ensure_connected() decorator to work properly. Co-authored-by: Matt Martz <matt@sivel.net> (cherry picked from commit 5eb7f57) Co-authored-by: Sam Doran <sdoran@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Different connection plugins return different data when throwing exceptions. The Paramiko connection plugin does not return a text string, which caused an exception.
The ssh connection plugin returns multi-line errors, which makes the debug logs harder to read. Only return the last line in that case in order to make the logs more readable.
Fixes #48948
ISSUE TYPE
COMPONENT NAME
reboot.py