Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using vault encrypted data with jinja2_native #49025

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Nov 22, 2018

SUMMARY

Fixes #48950

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/executor/module_common.py
lib/ansible/template/init.py

ADDITIONAL INFORMATION

@mkrizek mkrizek requested a review from abadger November 22, 2018 14:44
@ansibot
Copy link
Contributor

ansibot commented Nov 22, 2018

Hi @mkrizek, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 22, 2018
@abadger

This comment has been minimized.

@mkrizek

This comment has been minimized.

@mkrizek mkrizek changed the title Allow for native jinja vaulted strings as mod args Fix using vault encrypted data with jinja2_native Nov 23, 2018
Copy link
Contributor

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering about vaulted data that is not a string.

@@ -30,8 +32,13 @@ def ansible_native_concat(nodes):

if len(head) == 1:
out = head[0]

# TODO send unvaulted data to literal_eval?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vault dictionaries and lists. With this allow for that?

@abadger abadger added P3 Priority 3 - Approved, No Time Limitation and removed needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Nov 27, 2018
@bcoca bcoca merged commit d4568d9 into ansible:devel Nov 27, 2018
@mkrizek mkrizek deleted the issue-48950 branch November 28, 2018 06:36
mkrizek added a commit to mkrizek/ansible that referenced this pull request Nov 28, 2018
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
abadger pushed a commit that referenced this pull request Dec 4, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. P3 Priority 3 - Approved, No Time Limitation support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jinja2 native with vault encrypted var
5 participants