Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create local subversion server for tests #49047

Merged
merged 5 commits into from Dec 6, 2018
Merged

create local subversion server for tests #49047

merged 5 commits into from Dec 6, 2018

Conversation

jborean93
Copy link
Contributor

@jborean93 jborean93 commented Nov 23, 2018 •
edited

SUMMARY

Subversion 1.11 is not compatible with GitHub's subversion server implementation. In order to move across to the new Fedora versions, which use 1.11+, we need to stop using GitHub as a source repo in our tests. More info on this incompatibility can be found at https://mail-archives.apache.org/mod_mbox/subversion-users/201811.mbox/%3c1759573844.20181104160551@am-soft.de%3e.

This PR changes the test to setup it's own subversion server and use that instead.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

subversion

@ansibot
Copy link
Contributor

ansibot commented Nov 23, 2018

Hi @jborean93, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 23, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 23, 2018

The test ansible-test sanity --test shellcheck [explain] failed with 8 errors:

test/integration/targets/setup_subversion/files/create_repo.sh:1:1: SC2148 Tips depend on target shell and yours is unknown. Add a shebang.
test/integration/targets/setup_subversion/files/create_repo.sh:1:17: SC2086 Double quote to prevent globbing and word splitting.
test/integration/targets/setup_subversion/files/create_repo.sh:2:18: SC2086 Double quote to prevent globbing and word splitting.
test/integration/targets/setup_subversion/files/create_repo.sh:2:23: SC2086 Double quote to prevent globbing and word splitting.
test/integration/targets/setup_subversion/files/create_repo.sh:3:18: SC2086 Double quote to prevent globbing and word splitting.
test/integration/targets/setup_subversion/files/create_repo.sh:3:23: SC2086 Double quote to prevent globbing and word splitting.
test/integration/targets/setup_subversion/files/create_repo.sh:4:18: SC2086 Double quote to prevent globbing and word splitting.
test/integration/targets/setup_subversion/files/create_repo.sh:4:23: SC2086 Double quote to prevent globbing and word splitting.

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 23, 2018
@abadger abadger removed the needs_triage Needs a first human triage before being processed. label Nov 27, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 5, 2018

cc @dsummersl
click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed support:community This issue/PR relates to code supported by the Ansible community. core_review In order to be merged, this PR must follow the core review workflow. labels Dec 5, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Dec 5, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 5, 2018
@jborean93 jborean93 merged commit 0420d60 into ansible:devel Dec 6, 2018
@jborean93 jborean93 deleted the test-subversion branch December 6, 2018 03:41
jborean93 added a commit to jborean93/ansible that referenced this pull request Dec 6, 2018
@jborean93
create local subversion server for tests (ansible#49047)
b2b318b 
* create local subversion server for tests

* fix sanity issues

* don't touch system config when bringing up site

* removed original setup files

* fix opensuse config

(cherry picked from commit 0420d60)
jborean93 added a commit to jborean93/ansible that referenced this pull request Dec 6, 2018
@jborean93
create local subversion server for tests (ansible#49047)
a179330 
* create local subversion server for tests

* fix sanity issues

* don't touch system config when bringing up site

* removed original setup files

* fix opensuse config

(cherry picked from commit 0420d60)
jborean93 added a commit to jborean93/ansible that referenced this pull request Dec 6, 2018
@jborean93
create local subversion server for tests (ansible#49047)
87fd3ad 
* create local subversion server for tests

* fix sanity issues

* don't touch system config when bringing up site

* removed original setup files

* fix opensuse config

(cherry picked from commit 0420d60)
This was referenced Dec 6, 2018
Merged
Merged
Merged
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.5 #49583
stable-2.6 #49584
stable-2.7 #49585

abadger pushed a commit that referenced this pull request Dec 6, 2018
@jborean93 @abadger
create local subversion server for tests (#49047)
af03dd0 
* create local subversion server for tests

* fix sanity issues

* don't touch system config when bringing up site

* removed original setup files

* fix opensuse config

(cherry picked from commit 0420d60)
nitzmahone pushed a commit that referenced this pull request Dec 6, 2018
@jborean93 @nitzmahone
create local subversion server for tests (#49047) - 2.5 (#49583)
a280a8a 
* create local subversion server for tests (#49047)

* create local subversion server for tests

* fix sanity issues

* don't touch system config when bringing up site

* removed original setup files

* fix opensuse config

(cherry picked from commit 0420d60)

* manually add setup_passlib for 2.5
mattclay pushed a commit that referenced this pull request Dec 6, 2018
@jborean93 @mattclay
create local subversion server for tests (#49047)
1833a24 
* create local subversion server for tests

* fix sanity issues

* don't touch system config when bringing up site

* removed original setup files

* fix opensuse config

(cherry picked from commit 0420d60)
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@jborean93 @kbreit
create local subversion server for tests (ansible#49047)
35aff03 
* create local subversion server for tests

* fix sanity issues

* don't touch system config when bringing up site

* removed original setup files

* fix opensuse config
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @ansibot @abadger