Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for NIOS modules to use environment variables in provider #49056

Merged
merged 5 commits into from
Jan 14, 2019
Merged

Support for NIOS modules to use environment variables in provider #49056

merged 5 commits into from
Jan 14, 2019

Conversation

justjais
Copy link
Contributor

Signed-off-by: Sumit Jaiswal sjaiswal@redhat.com

SUMMARY

PR fixes the bug raised in issue #48697, and now environment variables can be set for username/password and used in provider making NIOS modules in sync with other network modules of using the environment variable for provider values.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nios/api.py

ADDITIONAL INFORMATION

@justjais justjais requested a review from gdpak November 23, 2018 12:22
@ansibot
Copy link
Contributor

ansibot commented Nov 23, 2018

Hi @justjais, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 23, 2018

cc @NilashishC @Qalthos @ganeshrn @gdpak @rcarrillocruz @sganesh-infoblox @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. infoblox Infoblox NIOS needs_triage Needs a first human triage before being processed. net_tools Net-tools category networking Network category small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. small_patch needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 23, 2018
@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Nov 27, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 27, 2018
@p9139010
Copy link

After modifying api.py & nios.py(defaults 2.1 WAPI) getting below error

fatal: [localhost]: FAILED! => {
"msg": "Could not find imported module support code for ('net_tools', 'nios', 'api'). Looked for either env_fallback.py or _basic.py"
}

@justjais
Copy link
Contributor Author

@p9139010 can you please elaborate what you have modified which is resulting in said error.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 6, 2018
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Dec 14, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 3, 2019

@justjais this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 3, 2019
@justjais
env var username/paswd support
3feb3b6 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
including all env vars of nios doc
5c6abed 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
fixing default wapi version in doc-s
7c306b0
@justjais
fixing review comment
0da70c5 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jan 4, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jan 12, 2019
@justjais
Copy link
Contributor Author

@bcoca can you please review and approve the PR

@justjais
review statement fix
8d8305d 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot ansibot removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jan 14, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 14, 2019
@justjais justjais merged commit 3f70518 into ansible:devel Jan 14, 2019
knumskull pushed a commit to knumskull/ansible that referenced this pull request Jan 21, 2019
@justjais @knumskull
Support for NIOS modules to use environment variables in provider (an…
e55f57e 
…sible#49056)

* env var username/paswd support

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* including all env vars of nios doc

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixing default wapi version in doc-s

* fixing review comment

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review statement fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais justjais deleted the 48697 branch June 4, 2019 10:40
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

@gdpak gdpak Awaiting requested review from gdpak

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. infoblox Infoblox NIOS net_tools Net-tools category networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justjais @ansibot @p9139010 @bcoca