Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scan_packages: made adding package managers easier #49079

Merged
merged 27 commits into from
Mar 6, 2019
Merged

scan_packages: made adding package managers easier #49079

merged 27 commits into from
Mar 6, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Nov 23, 2018

now it can scan for multiple package managers per system
also added portage support

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

scan_packages

@bcoca bcoca changed the title made adding package managers easier scan_packges: made adding package managers easier Nov 23, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 23, 2018

Hi @bcoca, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. and removed community_review In order to be merged, this PR must follow the community review workflow. ci_verified Changes made in this PR are causing tests to fail. labels Nov 23, 2018
@ansible ansible deleted a comment from ansibot Nov 23, 2018
@ansible ansible deleted a comment from ansibot Nov 23, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 23, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. core_review In order to be merged, this PR must follow the core review workflow. and removed owner_pr This PR is made by the module's maintainer. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 23, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Nov 24, 2018
bcoca and others added 26 commits March 5, 2019 17:28
@bcoca
moar pkg mgrs and moar info
a09313a 
 - added 'pkg' pkg manager (freebsd)
 - added pip
 - more apt info
@bcoca
updated clgo
1e07299
@webknjaz @bcoca
Updates from feedback
2157886 
Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
@bcoca
incorporated more feedback and added docstrings
4dfffe8
@bcoca
moar from feedback
cffc21a 
  - made manager list dynamic and names based on class
  - better not found msg
  - made abstract metaclass again
  - test is now init exception
  - module to global
  - better dedupe comments
@bcoca
more targetted errors/warnings
7e069b7
@bcoca
added strategy, reordered to conserve priority
e83060f
@bcoca
rpm > apt
4e1279d
@bcoca
move break to top
e963aca
@bcoca
fix trate
d274dab
@bcoca
piping it
ad55a37
@bcoca
lines and meta
3654b73
@bcoca
refactored common functions
09dd148 
 - moved pip into it's own module
 - cleaned up base clases
 - ensure 'lower' match in package_facts
@bcoca
missing license
a59c717
@bcoca
avoid facts
d2b4494
@bcoca
update clog
18d7943
@bcoca
addressed feedback
6c49a6e
@bcoca
fix clog
fe71be7
@bcoca
cleanup
8115116
@bcoca
upd
ebffad6
@bcoca
removed pip as that was removed
9620f67
@bcoca
renamed cpan
7dbd4dc
@bcoca
added a single line since 2 lines are needed to be
c71876a 
readabnle instead of just 1 line, it is a huge problem otherwise
@bcoca
fix internal ref
eae72f7
@bcoca
not intended in this round
35b29ce
@bcoca
updated as per fb
9b75a46
@bcoca bcoca merged commit b94bfed into ansible:devel Mar 6, 2019
@bcoca bcoca deleted the revamp_scan_pkgs branch March 6, 2019 17:29
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger abadger left review comments

@webknjaz webknjaz webknjaz left review comments

@mattclay mattclay mattclay left review comments

@maxamillion maxamillion maxamillion approved these changes

@Akasurde Akasurde Awaiting requested review from Akasurde

Assignees

@maxamillion maxamillion

Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bcoca @ansibot @abadger @maxamillion @webknjaz @mattclay