Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.7] wait_for: Add note about path and port #49118

Merged
merged 1 commit into from Nov 26, 2018
Merged

[Backport 2.7] wait_for: Add note about path and port #49118

merged 1 commit into from Nov 26, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

Path and Port are mutually exclusive parameters but not documented.
This fix documents this requirement.

Fixes: #15732

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
(cherry picked from commit 70f992c)

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

changelogs/fragments/15732-wait_for-documentation_fix.yaml
lib/ansible/modules/utilities/logic/wait_for.py

@Akasurde
[Backport 2.7] wait_for: Add note about path and port
69618da 
Path and Port are mutually exclusive parameters but not documented.
This fix documents this requirement.

Fixes: ansible#15732

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 70f992c)
@Akasurde Akasurde mentioned this pull request Nov 26, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

Hi @Akasurde, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

cc @AnderEnder @gregswift @jarv @jhoekx
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 26, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Nov 26, 2018
@acozine acozine merged commit 24eb3c5 into ansible:stable-2.7 Nov 26, 2018
@Akasurde Akasurde deleted the backport/2.7/15732 branch November 27, 2018 02:32
@Akasurde
Copy link
Member Author

@acozine Thanks for merge.

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Akasurde @ansibot @acozine