Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split PS wrapper and payload #49142

Merged
merged 1 commit into from
Nov 26, 2018
Merged

split PS wrapper and payload #49142

merged 1 commit into from
Nov 26, 2018

Conversation

nitzmahone
Copy link
Member

SUMMARY
  • addresses CVE-2018-16859
  • prevent scriptblock logging from logging payload contents
  • added tests to verify no payload contents in PS Operational event log
  • fix script action to send split-aware wrapper
  • fix CLIXML error parser (return to -EncodedCommand exposed problems with it)
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

powershell.py

ADDITIONAL INFORMATION

This was referenced Nov 26, 2018
Merged
Merged
Merged
@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

Hi @nitzmahone, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

cc @jborean93
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Nov 26, 2018
@nitzmahone
split PS wrapper and payload (CVE-2018-16859)
5a3dd50 
* prevent scriptblock logging from logging payload contents
* added tests to verify no payload contents in PS Operational event log
* fix script action to send split-aware wrapper
* fix CLIXML error parser (return to -EncodedCommand exposed problems with it)
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Nov 26, 2018
@nitzmahone nitzmahone merged commit 8c1f701 into ansible:devel Nov 26, 2018
@nitzmahone
Copy link
Member Author

unrelated transient test failure, merging

mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@nitzmahone @mjmayer
split PS wrapper and payload (CVE-2018-16859) (ansible#49142)
40351a5 
* prevent scriptblock logging from logging payload contents
* added tests to verify no payload contents in PS Operational event log
* fix script action to send split-aware wrapper
* fix CLIXML error parser (return to -EncodedCommand exposed problems with it)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nitzmahone @ansibot @jborean93