require git when trying to use it in ansible-galaxy cli #49212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we weren't setting `required=True` when calling `get_bin_path` and the path would return `None`, this would cause a traceback when attempting to ' '.join() to create a string representation of the failed command for error output Fixes ansible#49200 Signed-off-by: Adam Miller <admiller@redhat.com>
|
add changelog ? otherwise lgtm, also good candidate for backports |
bcoca
approved these changes
Nov 27, 2018
|
+1 |
|
Hi @maxamillion, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
Akasurde
approved these changes
Nov 28, 2018
Akasurde
removed
the
needs_triage
Signed-off-by: Adam Miller <admiller@redhat.com>
|
rebuild_merge |
ansibot
added
core_review
maxamillion
added a commit
to maxamillion/ansible
that referenced
this pull request
Nov 28, 2018
* require git when trying to use it in ansible-galaxy cli Previously we weren't setting `required=True` when calling `get_bin_path` and the path would return `None`, this would cause a traceback when attempting to ' '.join() to create a string representation of the failed command for error output Fixes ansible#49200 Signed-off-by: Adam Miller <admiller@redhat.com> * add changelog Signed-off-by: Adam Miller <admiller@redhat.com> (cherry picked from commit 81540bd)
abadger
pushed a commit
that referenced
this pull request
Dec 4, 2018
* require git when trying to use it in ansible-galaxy cli Previously we weren't setting `required=True` when calling `get_bin_path` and the path would return `None`, this would cause a traceback when attempting to ' '.join() to create a string representation of the failed command for error output Fixes #49200 Signed-off-by: Adam Miller <admiller@redhat.com> * add changelog Signed-off-by: Adam Miller <admiller@redhat.com> (cherry picked from commit 81540bd)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adam Miller admiller@redhat.com
SUMMARY
Fixes #49200
Previously we weren't setting
required=Truewhen callingget_bin_pathand the path would returnNone, this would cause a traceback when attempting to ' '.join() to create a string representation of the failed command for error outputISSUE TYPE
COMPONENT NAME
ansible-galaxy