ACME: improve error handling #49266
Merged
ACME: improve error handling #49266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @felixfontein, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
|
shipit |
ansibot
added
shipit
|
@resmo thanks for reviewing and merging! |
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Nov 29, 2018
* Improve error handling: when parse_json_result is False, still return the error message. * Remove content body from info dict. * Add changelog. (cherry picked from commit b842b1b)
This was referenced Nov 29, 2018
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Dec 2, 2018
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Dec 2, 2018
…ebble (ansible#49407) (cherry picked from commit 34c57b4)
abadger
pushed a commit
that referenced
this pull request
Dec 4, 2018
* Improve error handling: when parse_json_result is False, still return the error message. * Remove content body from info dict. * Add changelog. (cherry picked from commit b842b1b)
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jan 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Two general ACME improvements extracted from #48444, which should be backported:
parse_json_resultisFalseand an error occurs, returns the return body instead of{};infodict. (So if someone dumps theinfodict, it will only contain headers etc.).ISSUE TYPE
COMPONENT NAME
lib/ansible/module_utils/acme.py