dnf module load/init dnf pkg mgr plugins properly #49278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @maxamillion, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
Fixes ansible#45940 Signed-off-by: Adam Miller <admiller@redhat.com>
maxamillion
force-pushed
the
bugfix/45940-dnf-plugin-loading
branch
from
f0c5a4e
to
82916de
Compare
abadger
reviewed
Nov 29, 2018
| base.pre_configure_plugins() | ||
| base.configure_plugins() | ||
| except AttributeError: | ||
| pass # older versions of dnf didn't require this and don't have these methods |
There was a problem hiding this comment.
Can these configuration methods raise dnf.exceptions.RepoError? If not, they should probably be above the RepoError try: except instead of nested inside of it.
There was a problem hiding this comment.
@abadger not to the best of my knowledge, no ... will update 👍
ansibot
removed
the
needs_triage
Signed-off-by: Adam Miller <admiller@redhat.com>
|
Looks good. +1 to merge from me. |
|
rebuild_merge |
maxamillion
added a commit
to maxamillion/ansible
that referenced
this pull request
Nov 30, 2018
* dnf module load/init dnf pkg mgr plugins properly Fixes ansible#45940 Signed-off-by: Adam Miller <admiller@redhat.com> (cherry picked from commit 378cc96)
abadger
pushed a commit
that referenced
this pull request
Dec 4, 2018
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jan 11, 2019
* dnf module load/init dnf pkg mgr plugins properly Fixes ansible#45940 Signed-off-by: Adam Miller <admiller@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adam Miller admiller@redhat.com
SUMMARY
Fixes #45940
ISSUE TYPE
COMPONENT NAME
dnf