Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws] Revert back to getting the AWS role name from the URI #49427

Merged
merged 2 commits into from
Dec 4, 2018
Merged

[aws] Revert back to getting the AWS role name from the URI #49427

merged 2 commits into from
Dec 4, 2018
+6 −3

Conversation

roadmapper
Copy link
Contributor

SUMMARY
  • The role name and instance profile name can be different, the change made in Change IAM role name parsing to come from the ARN #45534 gets the instance profile name, not the role name
  • Change the delimiter to : for keys that are discovered through the JSON parsing (which is not a valid delimiter for AWS IAM role names), this delimiter is still converted to underscore
  • Now checks for the existence of that delimiter to remove the cases where the JSON keys are appended to the role name to find the role name

Actually fixes #45228

(cherry picked from commit ff9b86f)

Backport of #49113

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@roadmapper
Revert back to getting the AWS role name from the URI with a small ch…
0accfa6 
…ange (ansible#49113)

- The role name and instance profile name _can_ be different
- Change the delimiter to `:` for keys that are discovered through the JSON parsing (which is not a valid delimiter for AWS IAM role names), this delimiter is still converted to underscore
- Now checks for the existence of that delimiter to remove the cases where the JSON keys are appended to the role name to find the role name

(cherry picked from commit ff9b86f)
@roadmapper
Changelog update
2c4d80e
@ansibot
Copy link
Contributor

ansibot commented Dec 3, 2018

Hi @roadmapper, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 3, 2018
@abadger abadger merged commit aed38b1 into ansible:stable-2.7 Dec 4, 2018
@abadger
Copy link
Contributor

abadger commented Dec 4, 2018

Merged for 2.7.5

@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Dec 11, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roadmapper @ansibot @abadger @bcoca