Support version 3 of the redis python library #49445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
bcoca
reviewed
Dec 3, 2018
| @@ -99,7 +99,10 @@ def set(self, key, value): | |||
| else: | |||
| self._db.set(self._make_key(key), value2) | |||
|
|
|||
| self._db.zadd(self._keys_set, time.time(), key) | |||
| if VERSION[0] == 2: | |||
There was a problem hiding this comment.
we probably want <= 2 ... those using the OS package for redis python might have ancient libs
There was a problem hiding this comment.
As part of verifying that VERSION was available, I checked the tags in GitHub, and found that 2.4.6 (the oldest in GitHub) was released in Jul 13, 2011. It seems as though 2.4.5 was when VERSION was added. Roughly 2.4.5 was released around Jun 7, 2011.
As such, this change would put a requirement on at least 2.4.5, although I have no idea whether other functionality would work this far back.
There was a problem hiding this comment.
gtk, so it will just fail on import for older redis, we might want to capture that and state min requirement is 2.4.5
bcoca
approved these changes
Dec 3, 2018
ansibot
added
needs_revision
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Dec 5, 2018
…9445) * Support version 3 of the redis python library. Fixes ansible#49341 * Document 2.4.5 minimum redis-py version (cherry picked from commit 77de219) Co-authored-by: Matt Martz <matt@sivel.net>
abadger
pushed a commit
that referenced
this pull request
Dec 6, 2018
* Support version 3 of the redis python library. Fixes #49341 * Document 2.4.5 minimum redis-py version (cherry picked from commit 77de219) Co-authored-by: Matt Martz <matt@sivel.net>
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jan 11, 2019
* Support version 3 of the redis python library. Fixes ansible#49341 * Document 2.4.5 minimum redis-py version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Support version 3 of the redis python library. Fixes #49341
Version 3 added the following backwards incompatible change:
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/cache/redis.py
ADDITIONAL INFORMATION