docsite/build-site.py should use full path to index.html

[gundalow]

Before

foo@bar:~/ansible/mine/docsite$ ./build-site.py
~~snip~~
build succeeded, 1 warning.
gvfs-open: ~/ansible/mine/docsite/index.html: error opening location: Error when getting information for file '~ansible/mine/docsite/index.html': No such file or directory
foo@bar:~/ansible/mine/docsite$

After

Webpage opens in browser
Also tested "make webdocs" from top level

Also fixed minor typo in comment. Apologies if you prefer that in a separate change, let me know, I thought this would be pragmatic.

[mpdehaan]

What problem does this fix?

The way we build the site goes through "make docs" and I haven't encountered a problem doing that, so, curious...

[gundalow]

docsite/README.md informs the contributor about "make viewdocs"
which is different from toplevel "make docs" as it tries (and currently fails) to open the newly created index.html in your browser.

I believe all of the docsite makes go via build-site.py

The use case/workflow is:
hack rst files
make viewdocs
webbrowser opens with newly created html pages loaded

[mpdehaan]

got it, thanks!

Yeah, haven't used that target for a while :)

[gundalow]

Do you need any extra info, or does this just need the "docs_pull_request" label?

Let me know if you need anything else

[mpdehaan]

As we build all of this through the makefile I don't believe we need to change anything at this time.

[gundalow]

I believe "make webdocs" is also broken without this fix, but can not test at the moment as I'm traveling