Make squash deprecation messages less misleading

[sivel]

SUMMARY

This PR aims to make the package module squashing deprecation message less misleading when using lookups other than items or list.

As of now, you would get a message like the following, using with_lines:

[DEPRECATION WARNING]: Invoking "apt" only once while using a loop via
squash_actions is deprecated. Instead of using a loop to supply multiple items and
 specifying `name: {{ item }}`, please use `name: u'cat squash.txt'` and remove
the loop. This feature will be removed in version 2.11. Deprecation warnings can
be disabled by setting deprecation_warnings=False in ansible.cfg.

With this PR:

[DEPRECATION WARNING]: Invoking "apt" only once while using a loop via
squash_actions is deprecated. Instead of using a loop to supply multiple items and
 specifying `name: "{{ item }}"`, please use `name: "{{ query('lines', 'cat
squash.txt') }}"` and remove the loop. This feature will be removed in version
2.11. Deprecation warnings can be disabled by setting deprecation_warnings=False
in ansible.cfg

There are likely edge cases where this wont work, but this gets us closer.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lib/ansible/executor/task_executor.py

ADDITIONAL INFORMATION

[sivel]

bot_status

[ansibot]

Components

changelogs/fragments/squash-deprecation-message.yml
support: community
maintainers:

lib/ansible/executor/task_executor.py
support: core
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): sivel
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help