Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed if logic Type to boolean #49628

Merged
merged 3 commits into from
Dec 17, 2018
Merged

changed if logic Type to boolean #49628

merged 3 commits into from
Dec 17, 2018

Conversation

Alexander198961
Copy link
Contributor

@Alexander198961 Alexander198961 commented Dec 6, 2018 •
edited

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

s3_module

ADDITIONAL INFORMATION

We have requester_pays=dict(default='no', type='bool') variable and seems it can be True or False otherwise. not sure is it possible to have boolean type as None ?
but we tried to check against is None type before fix which seems to be not right ?

Ansible version
ansible 2.8.0.dev0

@Alexander198961
Copy link
Contributor Author

There is need some tests for me

@Alexander198961 Alexander198961 changed the title changed Type to boolean WIP changed Type to boolean Dec 6, 2018
@Alexander198961 Alexander198961 changed the title WIP changed Type to boolean WIP changed if logic Type to boolean Dec 6, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 6, 2018

cc @wimnat
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 6, 2018
@Alexander198961 Alexander198961 changed the title WIP changed if logic Type to boolean changed if logic Type to boolean Dec 6, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Dec 6, 2018
@Alexander198961 Alexander198961 mentioned this pull request Dec 8, 2018
Closed
@samdoran
Copy link
Contributor

Also change the default value for this parameter to False rather than no, or omit the default value for this parameter.

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Dec 11, 2018
@Alexander198961
Copy link
Contributor Author

@samdoiron @abadger could you pls review again ?

@samdoiron
Copy link
Contributor

@Alexander198961 Wrong ping 😄. @samdoran ^^

@Alexander198961
Copy link
Contributor Author

Sorry

@samdoran
Copy link
Contributor

Please create a changelog fragment. See fragments for examples.

@Alexander198961
Copy link
Contributor Author

@samdoran Done

@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Dec 12, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 13, 2018
@Alexander198961
Copy link
Contributor Author

@samdoran @abadger Could you pls review ? is it ok now?

@samdoran samdoran merged commit ba56204 into ansible:devel Dec 17, 2018
@samdoran
Copy link
Contributor

Please create a backport PR for this to be included in previous versions.

@Alexander198961
Copy link
Contributor Author

Alexander198961 commented Dec 25, 2018 •
edited

The previous version (stable-2.7) seems doesn't have such check
if requester_pays is not None:
so issue was with devel branch only

kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@Alexander198961 @kbreit
changed if logic Type to boolean (ansible#49628)
51a2ab7 
* changed Type to boolean

* fix after review

* created fragment
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger abadger left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Alexander198961 @ansibot @samdoran @samdoiron @abadger