mongodb_replicaset module and test exception

[rhysmeister]

SUMMARY

New module allowing the creation of mongodb replicasets. Based on existing mongodb modules.

Tidy up of previous PR: #43674

Includes changes requested by @maxamillion and @acozine

ISSUE TYPE

• New Module Pull Request

COMPONENT NAME

mongodb_replicaset

ADDITIONAL INFORMATION

ansible 2.7.1
  config file = None
  configured module search path = ['/Users/rhyscampbell/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/Cellar/python/3.6.4_2/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.4 (default, Jan  6 2018, 11:51:59) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]

[ansibot]

cc @mattclay
click here for bot help

[dagwieers]

Please add integration tests for this module. Look at test/integration/targets/ and more specifically check what is being done for postgresql and mysql to see how they set up a database, and then use it for testing.

We currently have no mongodb integration tests, and we have to fix that for all modules.

[rhysmeister]

@dagwieers Good to go here? PR for testing should be ready soon.

[rhysmeister]

Caught a bug in this module for MongoDB 4.0 found thanks to integration tests. Integration tests are working for MongoDB versions 3.2, 3.4, 3.6 and 4.0.

[dagwieers]

Given that this has been tested, and we are expecting integration tests as well. I am going to approve this PR.

[rhysmeister]

Great stuff. Thanks for your efforts in getting this merged.

[netjordan]

Hi @rhysmeister

At line 336 should
if arbiter_at_index is not None and len(members) - 1 > arbiter_at_index: module.fail_json(msg="MongoDB Replicaset validation failed. Invalid arbiter index.")

Should this actually be:
if arbiter_at_index is not None and len(members) - 1 < arbiter_at_index:

I can raise a PR if you agree?

[rhysmeister]

@netjordan Yes. Good catch. I'll ensure there's a test for this as well.