Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Module: na_ontap_quotas #49783

Merged
merged 8 commits into from
Mar 5, 2019
Merged

New Module: na_ontap_quotas #49783

merged 8 commits into from
Mar 5, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY
  • New Module Na_ontap_quotas. Allow for the creating/modifying and deleting of Quotas on ONTAP
  • Unit test for Modules
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • na_ontap_quotas
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. new_plugin This PR includes a new plugin. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 11, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 11, 2018

The test ansible-test sanity --test shebang [explain] failed with 1 error:

test/units/modules/storage/netapp/na_ontap_quotas.py:1:1: unexpected non-module shebang: b'#!/usr/bin/python'

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 11, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 11, 2018

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added module This issue/PR relates to a module. netapp new_module This PR includes a new module. storage support:community This issue/PR relates to code supported by the Ansible community. labels Dec 11, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 11, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_quotas.py:0:0: E305 DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got 'NetApp Ansible Team (ng-ansibleteam@netapp.com)'

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Dec 11, 2018
@samdoran samdoran removed needs_triage Needs a first human triage before being processed. labels Dec 11, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. labels Dec 11, 2018
@thedoubl3j
Copy link
Member

CI restarted per @gundalow

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 18, 2018
thedoubl3j
thedoubl3j reviewed Feb 14, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carchi8py any particular reason the test for ontap_cluster was removed?

@carchi8py
Copy link
Contributor Author

So looks like in my devel i deleted it, that was on accident, Problem with that is i use the same workspace to push out every change in the last month, so all my pull request now have a delete for this file.

Since i don't want to redo dozens of pull request i'll add a new one in a little bit to re-add the unit test.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 14, 2019
@gundalow
Copy link
Contributor

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 14, 2019
@carchi8py
Copy link
Contributor Author

Just realized i can revert the delete without causing any issues. So i'm going through all the existing pull request and reverting the delete of that one file.

@ansibot
Copy link
Contributor

ansibot commented Feb 14, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_quotas.py:0:0: E305 DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got 'NetApp Ansible Team (ng-ansibleteam@netapp.com)'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Feb 14, 2019
lonico
lonico approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 19, 2019
lonico
lonico approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 20, 2019
@thedoubl3j
Copy link
Member

cc @thaumos

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed shipit This PR is ready to be merged by Core labels Mar 4, 2019
@gundalow gundalow merged commit 04c6f94 into ansible:devel Mar 5, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

@lonico lonico lonico approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@carchi8py @ansibot @thedoubl3j @gundalow @lonico @samdoran