Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad-hoc command: fix 'any' call in play_ds #49852

Merged
merged 2 commits into from
Dec 16, 2018
Merged

Ad-hoc command: fix 'any' call in play_ds #49852

merged 2 commits into from
Dec 16, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY
  • Unit test for ad-hoc cli

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/cli/adhoc.py
test/units/cli/test_adhoc.py

@Akasurde Akasurde requested a review from bcoca December 13, 2018 07:39
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 13, 2018
mkrizek
mkrizek reviewed Dec 13, 2018
View reviewed changes
lib/ansible/cli/adhoc.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 13, 2018
@Akasurde
Ad-hoc command: fix 'any' call in play_ds
0b98970 
* Unit test for ad-hoc cli

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde
Review comments
bc02419 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 16, 2018
@Akasurde Akasurde merged commit 162d949 into ansible:devel Dec 16, 2018
@Akasurde Akasurde deleted the test_adhoc_fix branch December 16, 2018 05:37
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Dec 17, 2018
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@Akasurde @kbreit
Ad-hoc command: fix 'any' call in play_ds (ansible#49852)
f89dd39 
* Ad-hoc command: fix 'any' call in play_ds
* Unit test for ad-hoc cli
* Review comments

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek left review comments

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Akasurde @bcoca @mkrizek @sivel @ansibot