Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure play order is obeyed #49897

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Ensure play order is obeyed #49897

merged 2 commits into from
Feb 27, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Dec 13, 2018

it was being ignored depending on other options
fixes #49846

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

play

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 13, 2018
@ansible ansible deleted a comment from ansibot Dec 14, 2018
@bcoca bcoca changed the title Ensure play order is obeyed [wip] Ensure play order is obeyed Dec 14, 2018
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Dec 14, 2018
@sivel sivel removed needs_triage Needs a first human triage before being processed. labels Dec 18, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 27, 2018
@samdoran samdoran self-requested a review February 1, 2019 21:58
@sivel sivel mentioned this pull request Feb 14, 2019
Closed
@bcoca bcoca changed the title [wip] Ensure play order is obeyed Ensure play order is obeyed Feb 27, 2019
@bcoca
Ensure play order is obeyed
93e1e2d 
 it was being ignored depending on other options
 also added tests for each order (except shuffle) both serial and not
 fixes ansible#49846
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 27, 2019
samdoran
samdoran approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look great. Just ran them with and without this patch and they work properly.

@bcoca bcoca merged commit cfba6df into ansible:devel Feb 27, 2019
@bcoca bcoca deleted the fix_order_serial branch February 27, 2019 23:20
bcoca added a commit to bcoca/ansible that referenced this pull request Feb 27, 2019
@bcoca
Ensure play order is obeyed (ansible#49897)
674b479 
* Ensure play order is obeyed

 it was being ignored depending on other options
 also added tests for each order (except shuffle) both serial and not
 fixes ansible#49846


(cherry picked from commit cfba6df)
abadger pushed a commit that referenced this pull request Mar 1, 2019
@bcoca @abadger
Ensure play order is obeyed (#49897)
6bd7ef4 
* Ensure play order is obeyed

 it was being ignored depending on other options
 also added tests for each order (except shuffle) both serial and not
 fixes #49846


(cherry picked from commit cfba6df)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playbook play 'order' keyword has no effect
4 participants
@bcoca @samdoran @sivel @ansibot