Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide deprecation warnings on return values/facts #49900

Open
nitzmahone opened this issue Dec 13, 2018 · 4 comments
Open

Provide deprecation warnings on return values/facts #49900

nitzmahone opened this issue Dec 13, 2018 · 4 comments
Assignees
Labels
affects_2.17 data_tagging feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@nitzmahone
Copy link
Member

nitzmahone commented Dec 13, 2018

SUMMARY

Allow modules and actions to tag attributes of return values (including facts) as deprecated. Preserve the tagging within the controller and variable store, and only fire a deprecation warning when a tagged attribute is "touched" by a user-initiated event (usually templating).

This is prerequisite for the ultimate fix to #43798 (deprecating usage of all un-namespaced facts and eventually changing the default to namespaced-only).

Depends on #80747

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

AnsibleUnsafe

ADDITIONAL INFORMATION

Refactor AnsibleUnsafe to a new class that supports multiple types of tagging, and ensure that the various tagged data is always preserved if attempting to add a new tag. Trigger the warning when encountering a tagged value during templating.

@ansibot
Copy link
Contributor

ansibot commented Dec 13, 2018

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 13, 2018
@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label Dec 13, 2018
@nitzmahone nitzmahone added this to To Do - Backlog only. Anything Can be here. in Ansible 2.8 Dec 13, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 16, 2019

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot removed the module This issue/PR relates to a module. label Feb 16, 2019
@samdoran
Copy link
Contributor

Is this a feature we would still like to add, maybe in 2.11? Sounds like this may be on the potential 2.11 roadmap.

@nitzmahone
Copy link
Member Author

Yep, it sounds like @relrod wants to run with the generic tagging proxy, so we'll be writing it up Real Soon Now

@s-hertel s-hertel added affects_2.11 and removed affects_2.8 This issue/PR affects Ansible v2.8 labels Aug 20, 2021
@jborean93 jborean93 added this to TODO: proposed items in ansible-core 2.16 via automation Apr 12, 2023
@mattclay mattclay moved this from TODO: proposed items to Phase 1 (May 01 - Jun 23) in ansible-core 2.16 Apr 25, 2023
@mattclay mattclay self-assigned this Apr 25, 2023
@mattclay mattclay moved this from Phase 1 (May 01 - Jun 23) to Phase 2 (Jun 26 - Aug 04) in ansible-core 2.16 Aug 2, 2023
@mattclay mattclay moved this from Phase 2 (Jun 26 - Aug 04) to Delayed / Rejected in ansible-core 2.16 Aug 2, 2023
@mattclay mattclay added this to TODO: proposed items in ansible-core 2.17 via automation Aug 2, 2023
@mattclay mattclay moved this from TODO: proposed items to Phase 1 in ansible-core 2.17 Aug 2, 2023
@mattclay mattclay moved this from Phase 1 (Oct 16 - Dec 15) to Delayed / Rejected in ansible-core 2.17 Mar 19, 2024
@mattclay mattclay added this to In progress in ansible-core 2.18 Mar 19, 2024
@mattclay mattclay moved this from In progress to Phase 1 in ansible-core 2.18 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.17 data_tagging feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
ansible-core 2.16
  
Delayed / Rejected
ansible-core 2.17
  
Delayed / Rejected
ansible-core 2.18
  
Phase 1 (Apr 29 - Jun 21)
Ansible 2.8
  
To Do - Backlog only. Anything Can b...
Development

No branches or pull requests

6 participants