Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of cnos_interface module like what followed by other vendors #49927

Merged
merged 11 commits into from
Dec 19, 2018
Merged

Refactoring of cnos_interface module like what followed by other vendors #49927

merged 11 commits into from
Dec 19, 2018

Conversation

amuraleedhar
Copy link
Contributor

SUMMARY

Refactoring the cnos_interface , a function similiar in line to ios, eos etc.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

new file: test/integration/targets/cnos_interface/aliases
new file: test/integration/targets/cnos_interface/cnos_interface_sample_hosts
new file: test/integration/targets/cnos_interface/defaults/main.yaml
new file: test/integration/targets/cnos_interface/tasks/cli.yaml
new file: test/integration/targets/cnos_interface/tasks/main.yaml
new file: test/integration/targets/cnos_interface/tests/cli/basic.yaml
new file: test/integration/targets/cnos_interface/tests/cli/intent.yaml
new file: test/integration/targets/cnos_interface/vars/main.yaml
new file: test/units/modules/network/cnos/test_cnos_interface.py
modified: test/units/modules/network/cnos/fixtures/cnos_config_config.cfg
modified: lib/ansible/module_utils/network/cnos/cnos.py
modified: lib/ansible/modules/network/cnos/cnos_interface.py
deleted: test/units/modules/network/cnos/fixtures/cnos_ethernet_config.cfg
deleted: test/units/modules/network/cnos/test_cnos_ethernet.py
deleted: test/integration/targets/cnos_ethernet/README.md
deleted: test/integration/targets/cnos_ethernet/tasks/main.yml
deleted: test/integration/targets/cnos_ethernet/vars/main.yml
deleted: test/integration/targets/cnos_ethernet/aliases
deleted: test/integration/targets/cnos_ethernet/cnos_ethernet_sample_hosts

ANSIBLE VERSION

ansible 2.8.0.dev0 (devel e2b9c36) last updated 2018/10/12 13:58:41 (GMT +550)
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /home/ansible/sheru/ansible/lib/ansible
executable location = /home/ansible/sheru/ansible/bin/ansible
python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]

ADDITIONAL INFORMATION

Unit Test and Integration tests are also added which are succesfully tested with CNOS G8272 with image version 10.8.1

@ansibot
Copy link
Contributor

ansibot commented Dec 14, 2018

cc @NilashishC @Qalthos @dkasberg @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Dec 14, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 14, 2018

cc @mattclay
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Dec 14, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/cnos/cnos_interface.py:511:34: bad-whitespace Exactly one space required after comma         duplex=dict(default='auto',choices=['full', 'half', 'auto']),                                   ^

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/cnos/cnos_interface.py:511:35: E231 missing whitespace after ','

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 14, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 14, 2018

@amuraleedhar this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Dec 14, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 14, 2018
@amuraleedhar amuraleedhar mentioned this pull request Dec 14, 2018
Closed
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 19, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 19, 2018
@Qalthos Qalthos merged commit eab3b02 into ansible:devel Dec 19, 2018
@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Jan 2, 2019
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@kbreit
Refactoring of cnos_interface module like what followed by other vend…
b116307 
…ors (ansible#49927)

* Refactoring of cnos_interface module like what followed by other vendors

* To remove cnos-interface from E326 validation ignore list

* Effect of default parameters impacted UT
@amuraleedhar amuraleedhar deleted the cnos-refactor-interface branch February 19, 2019 11:49
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Mar 5, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. ios Cisco IOS community module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amuraleedhar @ansibot @dagwieers @Qalthos @bcoca