ovirt: default save true in setup host networks #49983

erav · 2018-12-16T13:14:02Z

Default value for save updated network configuration
during setup host networks is set to true.

SUMMARY

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ovirt_host_network

ADDITIONAL INFORMATION

needs update of the api-model and regeneration of ovirt-sdk4

ansibot · 2018-12-16T13:27:01Z

cc @machacekondra @mwperina
click here for bot help

ansibot · 2018-12-16T14:22:18Z

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_host_network.py:0:0: E324 Value for "default" from the argument_spec (True) for "save" does not match the documentation (False)

click here for bot help

ansibot · 2018-12-16T18:26:08Z

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_host_network.py:0:0: E324 Value for "default" from the argument_spec (True) for "save" does not match the documentation (False)

click here for bot help

ansibot · 2018-12-16T18:51:56Z

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_host_network.py:0:0: E324 Value for "default" from the argument_spec (True) for "save" does not match the documentation (False)

click here for bot help

dominikholler · 2018-12-17T08:55:25Z

Please check the "temporarily" in the doc section.
What happens, if this is module is executed against an old version of the ovirt-sdk, which does not expect the 'save' parameter?

machacekondra · 2018-12-17T12:02:27Z

Dominik is right, can you please just change the default value of the save parameter and change it's documentation. The save is implemneted in _action_save_configuration method. So it will work correctly but will be less effecient as it will do two API calls, but keep the compatibility with 4.2 version of the SDK/API.

erav · 2018-12-18T13:06:00Z

posted fix

machacekondra · 2018-12-18T13:14:25Z

lib/ansible/modules/cloud/ovirt/ovirt_host_network.py

@@ -74,7 +74,7 @@
        type: bool
    save:
        description:
-            - "If I(true) network configuration will be persistent, by default they are temporarily."
+            - "If I(false) network configuration will be temporary until next boot, by default they are persistent."


Can you please write that: Since Ansible 2.8 they are persisted by default? So it's clear.

ansibot · 2018-12-18T13:27:36Z

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_host_network.py:0:0: E324 Value for "default" from the argument_spec (True) for "save" does not match the documentation (False)

click here for bot help

ansibot · 2018-12-18T14:56:35Z

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_host_network.py:0:0: E324 Value for "default" from the argument_spec (True) for "save" does not match the documentation (False)

click here for bot help

Default value for save updated network configuration during setup host networks is set to true.

erav · 2019-02-27T12:54:32Z

@mwperina done

…

On Wed, Feb 27, 2019 at 2:35 PM ansibot ***@***.***> wrote: @erav <https://github.com/erav> this PR contains the following merge commits: - b686477 <b686477> Please rebase your branch <http://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html> to remove these commits. click here for bot help <https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#49983 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEf-CiPpHEtcwem28vsiZUvL8C60c-nmks5vRnuBgaJpZM4ZVNz5> .

machacekondra · 2019-02-27T13:01:15Z

shipit

mwperina · 2019-02-27T15:40:01Z

shipit

machacekondra · 2019-02-27T19:12:55Z

shipit

mwperina

shipit

mwperina · 2019-02-27T20:12:13Z

Dominik, you have requested changed in previous review, so will probably need to approve that PR to get it merged automatically

@dominikholler

mwperina · 2019-02-28T08:51:01Z

bot_status

ansibot · 2019-02-28T08:58:13Z

Components

lib/ansible/modules/cloud/ovirt/ovirt_host_network.py
support: community
maintainers: machacekondra mwperina

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): machacekondra mwperina
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

ansibot · 2019-03-08T12:25:19Z

cc @mnecas
click here for bot help

machacekondra · 2019-03-13T13:27:48Z

shipit

mnecas · 2019-03-13T14:03:17Z

shipit

machacekondra · 2019-03-13T14:18:56Z

bot_status

ansibot · 2019-03-13T14:25:33Z

Components

lib/ansible/modules/cloud/ovirt/ovirt_host_network.py
support: community
maintainers: machacekondra mnecas mwperina

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 3
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): machacekondra mwperina mnecas
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

mwperina · 2019-03-13T15:36:01Z

shipit

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Dec 16, 2018

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Dec 16, 2018

erav closed this Dec 16, 2018

erav reopened this Dec 16, 2018

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Dec 16, 2018

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Dec 16, 2018

ansibot removed the needs_triage Needs a first human triage before being processed. label Dec 17, 2018

machacekondra reviewed Dec 18, 2018

View reviewed changes

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Dec 18, 2018

ansibot added ci_verified Changes made in this PR are causing tests to fail. and removed ci_verified Changes made in this PR are causing tests to fail. labels Dec 18, 2018

erav and others added 3 commits February 27, 2019 14:39

Update ovirt_host_network.py

4329ec8

ovirt: default save true in setup host networks

7e72aac

Default value for save updated network configuration during setup host networks is set to true.

ovirt: default save true in setup host networks

2e5e823

Default value for save updated network configuration during setup host networks is set to true.

erav force-pushed the devel branch from 1ee9dcd to 2e5e823 Compare February 27, 2019 12:41

ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Feb 27, 2019

mwperina approved these changes Feb 27, 2019

View reviewed changes

dominikholler approved these changes Feb 28, 2019

View reviewed changes

ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 28, 2019

machacekondra approved these changes Feb 28, 2019

View reviewed changes

ansibot added automerge This PR was automatically merged by ansibot. and removed automerge This PR was automatically merged by ansibot. labels Mar 8, 2019

gundalow merged commit 1b48e47 into ansible:devel Mar 13, 2019

ansible locked and limited conversation to collaborators Jul 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ovirt: default save true in setup host networks #49983

ovirt: default save true in setup host networks #49983

erav commented Dec 16, 2018 •

edited

ansibot commented Dec 16, 2018

ansibot commented Dec 16, 2018

ansibot commented Dec 16, 2018

ansibot commented Dec 16, 2018

dominikholler commented Dec 17, 2018

machacekondra commented Dec 17, 2018

erav commented Dec 18, 2018

machacekondra Dec 18, 2018

ansibot commented Dec 18, 2018

ansibot commented Dec 18, 2018

erav commented Feb 27, 2019 via email

machacekondra commented Feb 27, 2019

mwperina commented Feb 27, 2019

machacekondra commented Feb 27, 2019

mwperina left a comment

mwperina commented Feb 27, 2019

mwperina commented Feb 28, 2019

ansibot commented Feb 28, 2019

ansibot commented Mar 8, 2019

machacekondra commented Mar 13, 2019

mnecas commented Mar 13, 2019

machacekondra commented Mar 13, 2019

ansibot commented Mar 13, 2019

mwperina commented Mar 13, 2019

ovirt: default save true in setup host networks #49983

ovirt: default save true in setup host networks #49983

Conversation

erav commented Dec 16, 2018 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibot commented Dec 16, 2018

ansibot commented Dec 16, 2018

ansibot commented Dec 16, 2018

ansibot commented Dec 16, 2018

dominikholler commented Dec 17, 2018

machacekondra commented Dec 17, 2018

erav commented Dec 18, 2018

machacekondra Dec 18, 2018

Choose a reason for hiding this comment

ansibot commented Dec 18, 2018

ansibot commented Dec 18, 2018

erav commented Feb 27, 2019 via email

machacekondra commented Feb 27, 2019

mwperina commented Feb 27, 2019

machacekondra commented Feb 27, 2019

mwperina left a comment

Choose a reason for hiding this comment

mwperina commented Feb 27, 2019

mwperina commented Feb 28, 2019

ansibot commented Feb 28, 2019

ansibot commented Mar 8, 2019

machacekondra commented Mar 13, 2019

mnecas commented Mar 13, 2019

machacekondra commented Mar 13, 2019

ansibot commented Mar 13, 2019

mwperina commented Mar 13, 2019

erav commented Dec 16, 2018 •

edited