Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACI: Add types to modules and doc fragment #49997

Merged
merged 2 commits into from
Dec 17, 2018
Merged

ACI: Add types to modules and doc fragment #49997

merged 2 commits into from
Dec 17, 2018

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Dec 17, 2018 •
edited

SUMMARY

We were still missing types for the ACI module parameters (as we expected #45805 to be merged).
This PR adds those types now.

This relates to #49966

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

ACI module docs

@dagwieers dagwieers added the aci Cisco ACI community label Dec 17, 2018
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 17, 2018
@dagwieers dagwieers changed the title ACI: Add types to module doc fragment ACI: Add types to modules and doc fragment Dec 17, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 17, 2018

@dagwieers This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. core_review In order to be merged, this PR must follow the core review workflow. labels Dec 17, 2018
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Dec 17, 2018
@acozine
Copy link
Contributor

acozine commented Dec 17, 2018

The needs_rebase and needs_revision labels have been added just in response to the number of files in this PR.

@acozine acozine merged commit e8885ee into ansible:devel Dec 17, 2018
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@dagwieers @kbreit
ACI: Add types to modules and doc fragment (ansible#49997)
fb0e864 
* ACI: Add types to module doc fragment

* Add types to ACI modules too
@dagwieers dagwieers added cisco Cisco technologies networking Network category labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dagwieers @ansibot @acozine