Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix order of dnf api operations so transactions don't fail #50038

Merged
merged 2 commits into from
Jan 2, 2019
Merged

fix order of dnf api operations so transactions don't fail #50038

merged 2 commits into from
Jan 2, 2019

Conversation

maxamillion
Copy link
Contributor

Signed-off-by: Adam Miller admiller@redhat.com

SUMMARY

Previously dnf.base.fill_sack() was called before
dnf.base.update_cache() which apparently breaks dnf transaction
logic as per https://bugzilla.redhat.com/show_bug.cgi?id=1658694

Fixes #49060

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

dnf

@maxamillion
fix order of dnf api operations so transactions don't fail
1334d03 
Previously dnf.base.fill_sack() was called before
dnf.base.update_cache() which apparently breaks dnf transaction
logic as per https://bugzilla.redhat.com/show_bug.cgi?id=1658694

Fixes ansible#49060

Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Dec 17, 2018

cc @DJMuggs @berenddeschouwer @ignatenkobrain
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 17, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Dec 18, 2018
@abadger
Copy link
Contributor

abadger commented Dec 18, 2018

Approval from me. Add a changelog to make it easy to backport and then it's good to merge from me

@maxamillion
add changelog and test case
732fdc5 
Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed owner_pr This PR is made by the module's maintainer. core_review In order to be merged, this PR must follow the core review workflow. labels Dec 18, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 27, 2018
@maxamillion
Copy link
Contributor Author

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 2, 2019
@maxamillion
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jan 2, 2019

Components

changelogs/fragments/dnf-update-cache-broken-transaction.yaml
support: community
maintainers:

lib/ansible/modules/packaging/os/dnf.py
support: core
maintainers: DJMuggs berenddeschouwer ignatenkobrain maxamillion

test/integration/targets/dnf/tasks/dnf.yml
support: core
maintainers: DJMuggs berenddeschouwer ignatenkobrain maxamillion

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): maxamillion
shipit_actors_other: []
automerge: automerge community support test failed

click here for bot help

@ansibot ansibot merged commit ca08488 into ansible:devel Jan 2, 2019
maxamillion added a commit to maxamillion/ansible that referenced this pull request Jan 2, 2019
@maxamillion
fix order of dnf api operations so transactions don't fail (ansible#5…
8321fcb 
…0038)

* fix order of dnf api operations so transactions don't fail

Previously dnf.base.fill_sack() was called before
dnf.base.update_cache() which apparently breaks dnf transaction
logic as per https://bugzilla.redhat.com/show_bug.cgi?id=1658694

Fixes ansible#49060

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog and test case

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit ca08488)
@maxamillion maxamillion mentioned this pull request Jan 2, 2019
Merged
abadger pushed a commit that referenced this pull request Jan 7, 2019
@maxamillion @abadger
fix order of dnf api operations so transactions don't fail (#50038)
853d464 
* fix order of dnf api operations so transactions don't fail

Previously dnf.base.fill_sack() was called before
dnf.base.update_cache() which apparently breaks dnf transaction
logic as per https://bugzilla.redhat.com/show_bug.cgi?id=1658694

Fixes #49060

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog and test case

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit ca08488)
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@maxamillion @kbreit
fix order of dnf api operations so transactions don't fail (ansible#5…
f35e113 
…0038)

* fix order of dnf api operations so transactions don't fail

Previously dnf.base.fill_sack() was called before
dnf.base.update_cache() which apparently breaks dnf transaction
logic as per https://bugzilla.redhat.com/show_bug.cgi?id=1658694

Fixes ansible#49060

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog and test case

Signed-off-by: Adam Miller <admiller@redhat.com>
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dnf moldule's update_cache: true mode is broken for Fedora 28+
4 participants
@maxamillion @ansibot @abadger @jborean93