Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_lineinfile - fix malformed returned json #50066

Merged
merged 1 commit into from
Dec 18, 2018
Merged

win_lineinfile - fix malformed returned json #50066

merged 1 commit into from
Dec 18, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

The .Add() methods for an ArrayList return the index in which the entry was added. This causes issues as the output JSON will be invalid due to the index numbers preceding the actual return json.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_lineinfile

@ansibot
Copy link
Contributor

ansibot commented Dec 18, 2018

cc @brianlloyd @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community labels Dec 18, 2018
@jborean93 jborean93 merged commit efda3ea into ansible:devel Dec 18, 2018
@jborean93 jborean93 deleted the win_lineinfile-out branch December 18, 2018 19:40
jborean93 added a commit to jborean93/ansible that referenced this pull request Dec 18, 2018
@jborean93
win_lineinfile - fix malformed returned json (ansible#50066)
08ca720 
(cherry picked from commit efda3ea)
jborean93 added a commit to jborean93/ansible that referenced this pull request Dec 18, 2018
@jborean93
win_lineinfile - fix malformed returned json (ansible#50066)
41d5419 
(cherry picked from commit efda3ea)
This was referenced Dec 18, 2018
Merged
Merged
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.6 #50104
stable-2.7 #50105

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Dec 18, 2018
abadger pushed a commit that referenced this pull request Jan 7, 2019
@jborean93 @abadger
win_lineinfile - fix malformed returned json (#50066)
3244f95 
(cherry picked from commit efda3ea)
mattclay pushed a commit that referenced this pull request Jan 7, 2019
@jborean93 @mattclay
win_lineinfile - fix malformed returned json (#50066)
daf5c86 
(cherry picked from commit efda3ea)
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@jborean93 @kbreit
win_lineinfile - fix malformed returned json (ansible#50066)
3356aef
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jborean93 @ansibot